Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid incremental updates to Qbvh #152

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Avoid incremental updates to Qbvh #152

merged 2 commits into from
Sep 11, 2023

Conversation

NiseVoid
Copy link
Contributor

The incremental updates on Qbvh don't work as intended, an issue about this has been open on rapier/parry for a long time but the issues are yet to be solved. For now it's faster and more stable to rebuild the Qbvh entirely ever frame.

@Jondolf Jondolf added C-Performance Improvements or questions related to performance bugfix A-Spatial-Query Relates to spatial queries, such as ray casting, shape casting, and intersection tests labels Sep 10, 2023
@Jondolf
Copy link
Owner

Jondolf commented Sep 11, 2023

Thanks, this seems to fix a lot of the issues regarding crashes and increasing memory usage without noticably degrading performance. This probably also closes #110 since the unwrap call no longer exists.

I would expect that incremental updates should be more efficient when done properly, so we should revisit this later, at least once dimforge/parry#146 and dimforge/rapier#450 are resolved.

I noticed that RemovedColliders doesn't seem to be used anywhere anymore and it's a private resource. Could you maybe remove it and the systems associated with it? It'll probably need to be added back at some point, but right now it has no purpose.

@Jondolf Jondolf linked an issue Sep 11, 2023 that may be closed by this pull request
@Jondolf Jondolf merged commit 06e9330 into Jondolf:main Sep 11, 2023
RJ pushed a commit to RJ/avian that referenced this pull request Sep 25, 2023
The incremental updates on Qbvh don't work as intended, an issue about this has been open on rapier/parry for a long time but the issues are yet to be solved. For now it's faster and more stable to rebuild the Qbvh entirely ever frame.
@Jondolf Jondolf added C-Bug Something isn't working and removed bugfix labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Spatial-Query Relates to spatial queries, such as ray casting, shape casting, and intersection tests C-Bug Something isn't working C-Performance Improvements or questions related to performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when removing colliders
2 participants