Use path objects throughout #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add temporary Path() conversions in consumers which will be removed as they are updated to use Path: - ScubaVolume.get_vol_opt() - ScubaDive.get_deocker_cmdline()
JonathonReinhart
force-pushed
the
use-path-objs
branch
from
c4b3afa to
cc731f8
Compare
This makes changing this much simpler.
This required more elaborate changes due to the fact that test_load_config_from_yaml_cached_file() uses mock.patch to count open() calls.
JonathonReinhart
force-pushed
the
use-path-objs
branch
from
cc731f8 to
92f10a7
Compare
JonathonReinhart
force-pushed
the
use-path-objs
branch
from
92f10a7 to
9c8384d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pathlib.Path, added in Python 3.4, is a welcome improvement to many places in Scuba, making it clear when objects are paths, and making many path manipulation actions much simpler.