Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jumping to an date does not work as long as the page scrolling is still happening #135

Closed
niklashomann opened this issue Jan 19, 2023 · 2 comments
Closed

Jumping to an date does not work as long as the page scrolling is still happening #135

niklashomann opened this issue Jan 19, 2023 · 2 comments
Assignees
@JonasWanke
Labels
T: Fix Type: :bug: Bug Fixes

Comments

@niklashomann
Copy link

First, thank you very much for your great package!

We have encountered an issue where we cannnot jump to an specific date (using the DateController) as long as the calendar is still scrolling horizontally. While this is already slightly problematic, this leads to another problem when the target date (the date we jump to) is far away from the current shown days. Then the height of the header for the current shown days gets invalidated (because for a short moment, the target date is the selected date) but it does not really change the date and the header height is not recalculated again for the current visible days.

Here is a video of the bug, the button at the top jumps to the current day.

Emulator.-.admin.2023-01-19.14-38-18.mp4
@niklashomann niklashomann added the T: Fix Type: :bug: Bug Fixes label Jan 19, 2023
@JonasWanke JonasWanke self-assigned this Jan 24, 2023
@JonasWanke
Copy link
Owner

This is fixed as part of v1.0.0-alpha.11

TruFelix added a commit to BettaSystems/timetable that referenced this issue Jan 24, 2023
@TruFelix
Squashed commit of the following:
d9c4158 
commit 4815598
Author: Jonas Wanke <[email protected]>
Date:   Tue Jan 24 18:24:08 2023 +0100

    Release v1.0.0-alpha.11

commit e7bae6d
Author: Jonas Wanke <[email protected]>
Date:   Tue Jan 24 18:18:38 2023 +0100

    Add more linter rules

commit 40f1b67
Author: Jonas Wanke <[email protected]>
Date:   Tue Jan 24 18:16:46 2023 +0100

    Update black_hole_flutter to ^1.0.0

commit ed2d0a0
Author: Jonas Wanke <[email protected]>
Date:   Tue Jan 24 18:14:42 2023 +0100

    Upgrade Dart to v2.18.0, Flutter to v3.3.0

commit 59b0eb4
Author: Jonas Wanke <[email protected]>
Date:   Tue Jan 24 15:40:14 2023 +0100

    Add DateScrollActivity

    Closes: JonasWanke#110

commit 8855d85
Author: Jonas Wanke <[email protected]>
Date:   Tue Jan 24 15:39:34 2023 +0100

    Implement Diagnosticable for VisibleDateRange

commit 469a0de
Author: Jonas Wanke <[email protected]>
Date:   Tue Jan 24 15:38:46 2023 +0100

    Add DateDiagnosticsProperty

commit b35b240
Author: Jonas Wanke <[email protected]>
Date:   Tue Jan 24 15:38:31 2023 +0100

    Fix allDayEventBorder.toString()

commit 174387e
Author: Jonas Wanke <[email protected]>
Date:   Tue Jan 24 15:38:09 2023 +0100

    Fix formatting

commit 8e0315c
Author: Jonas Wanke <[email protected]>
Date:   Tue Jan 24 12:36:34 2023 +0100

    Honor maxWidth in WeekIndicator

    Closes: JonasWanke#131

commit b2f06cf
Author: Jonas Wanke <[email protected]>
Date:   Tue Jan 24 12:03:19 2023 +0100

    Remove superfluous num type arguments

commit 763661e
Author: Jonas Wanke <[email protected]>
Date:   Tue Jan 24 11:51:44 2023 +0100

    Fix MonthPageView's shrinkWrapped height when jumping to far-away date

commit c0167c2
Author: Jonas Wanke <[email protected]>
Date:   Tue Jan 24 11:51:04 2023 +0100

    Cancel animation when jumping in Date-/TimeController

    Closes JonasWanke#135
@niklashomann
Copy link
Author

niklashomann commented Jan 25, 2023 •
edited
Loading

Thanks for your response!

I have just updated my dependency, but sadly this problem still persist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JonasWanke JonasWanke

Labels
T: Fix Type: :bug: Bug Fixes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JonasWanke @niklashomann