Format send result to work with ethers #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanchristo
force-pushed
the
fix/ethers-support-and-formatting
branch
from
b851368 to
a0c0ab2
Compare
chmanie
suggested changes
Aug 17, 2018
RemoteMetaMaskProvider.js
Outdated
|
|
||
| // Format "gasPrice" | ||
| if (result && typeof result.gasPrice === 'string') { | ||
| result.gasPrice = Number(result.gasPrice); |
There was a problem hiding this comment.
I think I'd rather see parseInt(x, 10) here as it is more explicit
RemoteMetaMaskProvider.js
Outdated
|
|
||
| // Because requests are handled across a WebSocket, their callbacks need to | ||
| // be associated with an ID which is returned with the response. | ||
| const requestId = RemoteMetaMaskProvider.generateRequestId(); |
There was a problem hiding this comment.
We like to use this.constructor.xxx instead.
chmanie
approved these changes
Aug 17, 2018
chmanie
reviewed
Aug 17, 2018
RemoteMetaMaskProvider.js
Outdated
| if (result && result.logIndex) { | ||
| const array = []; | ||
| array.push(result); | ||
| return array; |
There was a problem hiding this comment.
Isn't that the same as return [result]?
ryanchristo
force-pushed
the
fix/ethers-support-and-formatting
branch
from
2eb40e7 to
ee60f08
Compare
|
@chmanie It's working with the latest commit! Could you please review once more? |
chmanie
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
formatResultstatic function toRemoteMetamaskProvider, which ensures thegasPriceandvalueof the result object are properly formatted to work withethers. IfgasPriceorvalueis a string, the string is converted to a number usingparseInt.Ideally, we would convert the string to a standard big number type but
ethersdoes not support any big number types other than its own proprietary type usingethers.utils.bigNumberify.Also adds a condition to
formatResultthat returns the result in an array if the result object has alogIndexproperty. This provides the correct formatting foreht_filterto work withethers.Other Changes
Added comments and updated formatting.
Related Issues
JoinColony/colonyStarter#14