Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint and reformat javascript files #7

Merged
merged 4 commits into from
Aug 11, 2018
Merged

Add eslint and reformat javascript files #7

merged 4 commits into from
Aug 11, 2018

Conversation

ryanchristo
Copy link
Contributor

Description

Add @colony/eslint-config-colony and associated dependencies and reformat javascript files.

Other Changes

Add .gitignore file and ignore node_modules.

Dependencies

Added:

  "devDependencies": {
    "@colony/eslint-config-colony": "^4.0.0",
    "babel-eslint": "^8.0.2",
    "eslint": "^4.17.0",
    "eslint-config-airbnb-base": "^12.1.0",
    "eslint-config-prettier": "^2.9.0",
    "eslint-import-resolver-jest": "^2.1.1",
    "eslint-plugin-flowtype": "^2.44.0",
    "eslint-plugin-import": "^2.8.0",
    "eslint-plugin-prettier": "^2.6.0",
    "prettier": "^1.10.2"
  }

@ryanchristo ryanchristo requested a review from chmanie August 10, 2018 07:44
@ryanchristo ryanchristo self-assigned this Aug 10, 2018
chmanie
chmanie reviewed Aug 11, 2018
View reviewed changes
RemoteMetaMaskProvider.js
}
return s4() + s4() + '-' + s4() + '-' + s4() + '-' + s4() + '-' + s4() + s4() + s4();
return `
${this.s4()}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

chmanie
chmanie approved these changes Aug 11, 2018
View reviewed changes
Copy link
Member

@chmanie chmanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ryanchristo, that looks good!

@chmanie chmanie force-pushed the enhancement/add-eslint-and-format branch from 443371a to 0849e74 Compare August 11, 2018 08:30
@chmanie chmanie merged commit fd00ad6 into master Aug 11, 2018
@chmanie chmanie deleted the enhancement/add-eslint-and-format branch August 11, 2018 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmanie chmanie chmanie approved these changes

Assignees

@ryanchristo ryanchristo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanchristo @chmanie