Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined request callback method #6

Merged
merged 1 commit into from
Aug 11, 2018
Merged

Fix undefined request callback method #6

merged 1 commit into from
Aug 11, 2018

Conversation

ryanchristo
Copy link
Contributor

Description

Fixes ReferenceError: requestCallback is not defined

Adds const requestCallback = this._callbacks.get(responseRequestId);

Closes #3

@ryanchristo ryanchristo requested a review from chmanie August 10, 2018 06:04
@ryanchristo ryanchristo self-assigned this Aug 10, 2018
chmanie
chmanie approved these changes Aug 11, 2018
View reviewed changes
Copy link
Member

@chmanie chmanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

@chmanie chmanie merged commit 4122f39 into master Aug 11, 2018
@chmanie chmanie deleted the fix/request-callback-method branch August 11, 2018 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmanie chmanie chmanie approved these changes

Assignees

@ryanchristo ryanchristo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanchristo @chmanie