SVN finds a lot of irrelevant repositories

[Yanpas]

• VSCode Version: 1.42
• OS Version: kubuntu linux 19.10
• Extension Version: 2.7.2
• System Language: ru_RU.UTF-8
• SVN Version: 1.10.6

Issue

Steps to Reproduce

Don't know exact steps but seems this issue appeared recently, maybe after 2.7.1 or 2.7.2 , or maybe after vscode update.

• open file history view
• click on some older revisons, the diff is opened
• vscode goes slow and searches for all folders with svn on my system

SVN Output

 svn info --xml
[cwd]$ svn info --xml //proc/4137/cwd
[cwd]$ svn stat --xml --no-ignore --ignore-externals
[cwd]$ svn info --xml
[cwd]$ svn info --xml //proc/4290/cwd
[cwd]$ svn info --xml
[cwd]$ svn info --xml //proc/4347/cwd
[cwd]$ svn info --xml
[cwd]$ svn: E125001: Couldn't determine absolute path of '.'
[cwd]$ svn: E000002: No such file or directory[cwd]$ svn info --xml
[cwd]$ svn: E125001: Couldn't determine absolute path of '.'
[cwd]$ svn: E000002: No such file or directory[cwd]$ svn info --xml
[cwd]$ svn info --xml //proc/6395/cwd
[cwd]$ svn info --xml
[cwd]$ svn info --xml //proc/6409/cwd
[co3]$ svn info --xml
[co3]$ svn info --xml //var/yan/co3
[searchtrunk]$ svn info --xml
[searchtrunk]$ svn info --xml //var/yan/searchtrunk
[trunk_co2]$ svn info --xml
[cwd]$ svn info --xml
[cwd]$ svn stat --xml --no-ignore --ignore-externals
[trunk_co2]$ svn info --xml //var/yan/trunk_co2
[cwd]$ svn info --xml
[cwd]$ svn stat --xml --no-ignore --ignore-externals
[cwd]$ svn info --xml
[cwd]$ svn stat --xml --no-ignore --ignore-externals
[cwd]$ svn info --xml
[cwd]$ svn stat --xml --no-ignore --ignore-externals
[cwd]$ svn info --xml
[co3]$ svn stat --xml --no-ignore --ignore-externals
[co3]$ svn info --xml
[searchtrunk]$ svn stat --xml --no-ignore --ignore-externals
[searchtrunk]$ svn info --xml
[trunk_co2]$ svn stat --xml --no-ignore --ignore-externals
[trunk_co2]$ svn info --xml

Screenshots

[JohnstonCode]

Can you have a look at 35ac8db to see if that is the cause

[Yanpas]

This commit looks ok (The bug reproduces after clicking on item log provider). I think it's tempfs, looks like it searches in /proc.

[JohnstonCode]

Yeah i can see the proc calls, strange.

[Yanpas]

[Yanpas]

A hotfix:

diff --git a/src/source_control_manager.ts b/src/source_control_manager.ts
index e16cefc..477973a 100644
--- a/src/source_control_manager.ts
+++ b/src/source_control_manager.ts
@@ -141,7 +141,7 @@ export class SourceControlManager implements IDisposable {
     );
     const onPossibleSvnRepositoryChange = filterEvent(
       onWorkspaceChange,
-      uri => !this.getRepository(uri)
+      uri => uri.scheme === "file" && !this.getRepository(uri)
     );
     onPossibleSvnRepositoryChange(
       this.onPossibleSvnRepositoryChange,

What was happening is that the whole root was scanned for the depth 4.