Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl + Enter for commit doesn't give option to choose "Selected" files #472

Closed
jackbanditdude opened this issue Jan 31, 2019 · 3 comments · Fixed by #811
Closed

Ctrl + Enter for commit doesn't give option to choose "Selected" files #472

jackbanditdude opened this issue Jan 31, 2019 · 3 comments · Fixed by #811
Labels
enhancement feature request released tortoise replacement

Comments

@jackbanditdude
Copy link

When pressing Ctrl + Enter to commit, if you've specifically selected files, the pop-up dialog asks if you'd like to commit Changes or Changelist "Default", it does not either automatically choose selected files or even give the option.

The ideal solution IMO would be to add "Selected" to the pop-up dialog asking which files to commit.
@edgardmessias
Copy link
Contributor

At momment, you can use changelists, like example, a changelist "tocommit", on Ctrl + Enter prompt you to choose a changelist

@edgardmessias
Copy link
Contributor

@JohnstonCode, we can use with: https://code.visualstudio.com/api/references/vscode-api#QuickPick%3CT%3E

Default all files selected.

For "Commit selected files" command, we can change to show same list, but only some files selected

edgardmessias added a commit to edgardmessias/svn-scm that referenced this issue Feb 14, 2020
@edgardmessias
feat: Allow select files to commit when choose "changes" (close Johns…
def4a94 
…tonCode#472)
@JohnstonCode JohnstonCode mentioned this issue Feb 18, 2020
Merged
@JohnstonCode JohnstonCode linked a pull request Feb 18, 2020 that will close this issue
feat: Allow select files to commit when choose "changes" (close #472) #811
Merged
JohnstonCode pushed a commit that referenced this issue Feb 19, 2020
@edgardmessias
feat: Allow select files to commit when choose "changes" (close #472) (…
ba4e806 
…#811)
JohnstonCode added a commit that referenced this issue Feb 19, 2020
@JohnstonCode
chore(release): 2.9.0 [skip ci]
032ece8 
# [2.9.0](v2.8.0...v2.9.0) (2020-02-19)

### Features

* Allow select files to commit when choose "changes" (close [#472](#472)) ([#811](#811)) ([ba4e806](ba4e806))
@JohnstonCode
Copy link
Owner

🎉 This issue has been resolved in version 2.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement feature request released tortoise replacement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Allow select files to commit when choose "changes" (close #472) edgardmessias/svn-scm
3 participants
@edgardmessias @jackbanditdude @JohnstonCode