Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right click ignore try to add ignore the opened file not a right clicked file #421

Closed
Thaina opened this issue Nov 22, 2018 · 4 comments · Fixed by #425
Closed

Right click ignore try to add ignore the opened file not a right clicked file #421

Thaina opened this issue Nov 22, 2018 · 4 comments · Fixed by #425

Comments

@Thaina
Copy link

Thaina commented Nov 22, 2018

  • VSCode Version: 1.29.1
  • OS Version: Windows 10
  • Extension Version: 1.46.2

Issue

When I try to use context menu right click to add ignore file, it try to ignore the current opened file instead of the file I right clicked on

Steps to Reproduce

  • Select some file and it opened on the main window, in this case .csproj

image

  • Right click on other file and select ignore, in this case .gradle

image

  • The option just show option for the opened file .csproj, not clicked file

image

This bug also made me cannot ignore folder because we can't make the folder be active item

@edgardmessias
Copy link
Contributor

@JohnstonCode, When context call the command, use the structure: (mainUri: Uri, allUris: Uri[])

The mainUri is the right click and allUris are all selected files

@JohnstonCode
Copy link
Owner

Yeah context for SCM view returns different values

@edgardmessias
Copy link
Contributor

Small note about right click in VSCode:

  • Right click on selected file, all selected files are used
  • Right click on non selected file only the file are used

If you select 10 files, and right click on non selected file, the 10 files are ignore by right click

@JohnstonCode
Copy link
Owner

🎉 This issue has been resolved in version 1.46.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants