Add Dockerfile #655
Add Dockerfile #655
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #655 +/- ##
==========================================
- Coverage 97.27% 97.27% -0.01%
==========================================
Files 15 16 +1
Lines 5845 6124 +279
==========================================
+ Hits 5686 5957 +271
- Misses 159 167 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Hi, thanks for the quick response. Your project has been very helpful for me. I opened this PR as a starting point, I'd be happy to update the README as well. Ideally the image can also be published to Dockerhub via GitHub Actions if you're open to it. Do you have any preferred approach for this? |
|
No preference. I've never actually used Docker, so not sure. If we need to setup a docker hub account, I can do that once the basic push action is ready. I know github also has a container registry we could push to. Let me know what you need |
|
|
||
| FROM gcr.io/distroless/cc | ||
| COPY --from=build /app/target/release/stylua / | ||
| CMD ["./stylua"] |
There was a problem hiding this comment.
I don't know too much about Docker, but is it worth configuring an ENTRYPOINT as well? It seems that allows it to be used through docker run
There was a problem hiding this comment.
You can still use docker run with CMD, I think this is the right way. From what I understand ENTRYPOINT is more for when you still want the ENTRYPOINT to run in addition to specifying an additional command which I don't think is the case for a CLI tool.
You can try like this:
$ docker build . -t stylua
$ docker run stylua /stylua "*.lua"
error: no file or directory found matching '*.lua'
|
Also, lets build to the GitHub Container Registry as well just so its available as much as possible https://docs.github.com/en/actions/publishing-packages/publishing-docker-images#publishing-images-to-docker-hub-and-github-packages |
Co-authored-by: JohnnyMorganz <[email protected]>
Hey, I don't think there is any reason to publish to Docker Hub and GHCR and it wouldn't restrict its available having it in one or the other. Also, I don't really have a strong preference for one over the other. |
Well I tested the Dockerfile by building it locally. You added tokens for Docker Hub or GHCR? I should update the PR to push to the right repository and I suppose to test I can just modify the triggers or create a test job? |
I did it for docker hub. I think it should be fine to trigger an example yeah |
|
Okay, can you trigger the workflow then? I don't think I have permissions but the workflow should work now. |
|
Looks like forks don't have access to repo secrets, so I copied over the files to another PR #658 and ran the action, and looks like its successful: https://github.com/JohnnyMorganz/StyLua/actions/runs/4374456725/jobs/7653906665 https://hub.docker.com/r/johnnymorganz/stylua/tags |
|
Thank you! |
It would be nice if this tool could also be distributed as a Docker image in addition to the existing packages.
This would make it much easier to build multi-platform images without manually checking the architecture and downloading the right binary.