Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix var expression collapsing when containing comments #502

Merged
merged 5 commits into from
Jul 20, 2022

Conversation

JohnnyMorganz
Copy link
Owner

Fixes #500

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #502 (7937a3f) into master (f386cf1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
- Coverage   97.66%   97.66%   -0.01%     
==========================================
  Files          14       14              
  Lines        5351     5346       -5     
==========================================
- Hits         5226     5221       -5     
  Misses        125      125              
Impacted Files Coverage Δ
src/formatters/expression.rs 97.07% <100.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f386cf1...7937a3f. Read the comment docs.

@github-actions
Copy link
Contributor

Repo Comparison Test

diff --git ORI/zombie-strike/src/shared/ReplicatedStorage/Core/Settings.lua ALT/zombie-strike/src/shared/ReplicatedStorage/Core/Settings.lua
index ec53467..82c6568 100644
--- ORI/zombie-strike/src/shared/ReplicatedStorage/Core/Settings.lua
+++ ALT/zombie-strike/src/shared/ReplicatedStorage/Core/Settings.lua
@@ -123,7 +123,9 @@ function Settings.GetSettingIndex(settingName, player)
 
 		error("unknown setting " .. settingName)
 	else
-		return LocalPlayer:WaitForChild("PlayerData", math.huge):WaitForChild("Settings"):WaitForChild(settingName).Value
+		return LocalPlayer:WaitForChild("PlayerData", math.huge)
+			:WaitForChild("Settings")
+			:WaitForChild(settingName).Value
 	end
 end
 

@JohnnyMorganz JohnnyMorganz merged commit fe8c8e3 into master Jul 20, 2022
@JohnnyMorganz JohnnyMorganz deleted the var-expression-comments branch July 20, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line comments are collapsed which causes code to break
2 participants