Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SparkNLP 1077- Introducing Qwen2 - VL #14474

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

prabod
Copy link
Contributor

@prabod prabod commented Dec 10, 2024

This PR Integrates Qwen2-VL family models into SparkNLP

Screenshots (if appropriate):

Types of changes

  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12251433223

Details

  • 24 of 417 (5.76%) changed or added relevant lines in 13 files are covered.
  • 57 unchanged lines in 37 files lost coverage.
  • Overall coverage decreased (-0.9%) to 59.492%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/scala/com/johnsnowlabs/nlp/HasBatchedAnnotateImage.scala 0 2 0.0%
src/main/scala/com/johnsnowlabs/nlp/ImageAssembler.scala 8 10 80.0%
src/main/scala/com/johnsnowlabs/nlp/annotators/tokenizer/bpe/BpeTokenizer.scala 1 3 33.33%
src/main/scala/com/johnsnowlabs/nlp/annotators/cv/feature_extractor/Preprocessor.scala 0 3 0.0%
src/main/scala/com/johnsnowlabs/nlp/pretrained/PretrainedPipeline.scala 0 4 0.0%
src/main/scala/com/johnsnowlabs/nlp/annotators/tokenizer/bpe/BpeSpecialTokens.scala 0 6 0.0%
src/main/scala/com/johnsnowlabs/nlp/AnnotationImage.scala 2 10 20.0%
src/main/scala/com/johnsnowlabs/nlp/LightPipeline.scala 13 34 38.24%
src/main/scala/com/johnsnowlabs/nlp/annotators/tokenizer/bpe/Qwen2VLTokenizer.scala 0 24 0.0%
src/main/scala/com/johnsnowlabs/nlp/annotators/tokenizer/bpe/BertTokenizer.scala 0 26 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/scala/com/johnsnowlabs/nlp/util/SparkNlpConfig.scala 1 50.0%
src/main/scala/com/johnsnowlabs/nlp/annotators/er/EntityRulerModel.scala 1 90.4%
src/main/scala/com/johnsnowlabs/nlp/annotators/ner/dl/NerDLModel.scala 1 58.23%
src/main/scala/com/johnsnowlabs/nlp/annotators/spell/norvig/NorvigSweetingModel.scala 1 84.17%
src/main/scala/com/johnsnowlabs/nlp/annotators/cv/util/transform/ImageResizeUtils.scala 1 81.4%
src/main/scala/com/johnsnowlabs/nlp/annotators/keyword/yake/YakeKeywordExtraction.scala 1 97.44%
src/main/scala/com/johnsnowlabs/nlp/annotators/TextSplitter.scala 1 94.44%
src/main/scala/com/johnsnowlabs/nlp/annotators/tokenizer/moses/MosesTokenizer.scala 1 96.55%
src/main/scala/com/johnsnowlabs/nlp/annotators/DocumentCharacterTextSplitter.scala 1 96.72%
src/main/scala/com/johnsnowlabs/nlp/AnnotationImage.scala 1 23.53%
Totals Coverage Status
Change from base Build 12237686398: -0.9%
Covered Lines: 9223
Relevant Lines: 15503

💛 - Coveralls

@prabod prabod self-assigned this Feb 12, 2025
Signed-off-by: Prabod Rathnayaka <[email protected]>
Signed-off-by: Prabod Rathnayaka <[email protected]>
@prabod prabod force-pushed the SPARKNLP-1077-Implementing-new-Qwen2-VL-models branch from ec490b5 to 16c9716 Compare February 13, 2025 22:48
@prabod prabod requested a review from maziyarpanahi February 13, 2025 22:49
Signed-off-by: Prabod Rathnayaka <[email protected]>
@prabod prabod marked this pull request as ready for review February 14, 2025 01:14
@prabod prabod added new-feature Introducing a new feature DON'T MERGE Do not merge this PR labels Feb 14, 2025
Signed-off-by: Prabod Rathnayaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DON'T MERGE Do not merge this PR new-feature Introducing a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants