Automatic PageBreaks disappear

[deepsaggas]

While editing the line just before 'computedPageBreak', page break disappears.
How to reproduce:

1. Open a pad with enough text such that it has a pagebreak (automatic ones not manual).
2. Now edit a line just before computedPageBreak(line which contains div with class='pageBreakComputed').
3. The computedPageBreak disappears

Possible reason for failure:
redrawPageBreaks() is not called from aceEditEvent hook because callstack type is

1. idleWorkTimer with callstack.callstack.docTextChanged = true or
2. handleKeyEvent with callstack.callstack.docTextChanged = false

[JohnMcLear]

Is this proving to be a major issue for you? I feel like by fixing it we will lose a lot of optimizations!

[deepsaggas]

It is an issue that I think should be fixed but on the other hand if it makes editing too slow, then there is no point in fixing it as page breaks are secondary, they will be used less than typing text obviously.
Were you able to isolate the issue?

[deepsaggas]

closed by mistake

[monkey-pawan]

Hi, any update here? I would like to know the fix, please. Even if you can't commit the fix to repository due to optimization issue or whatnot.

[JohnMcLear]

I'm not working on it due to not having time to work on it, you should hire a freelancer to work on it.

[monkey-pawan]

It's very unlikely to remember what you did about 2 years ago, but if by any chance you remember anything and give me a hint or point me to something useful, I would really appreciate it.

I tried calling reDrawPageBreaks() at aceEditEvent, it stopped disappearing but created other issues like generating new <div>s on Up Arrow. Thank you for your time, even if you don't remember. 😅 Awesome work you did in all those years. 👍

[JohnMcLear]

sorry

…

________________________________ From: monkey-pawan <[email protected]> Sent: 26 Oct 2017 1:50 pm To: ether/ep_page_view Cc: John McLear; Assign Subject: Re: [ether/ep_page_view] Automatic PageBreaks disappear (#20) It's very unlikely to remember what you did about 2 years ago, but if by any chance you remember anything and give me a hint or point me to something useful, I would really appreciate it. I tried calling reDrawPageBreaks() at aceEditEvent<https://github.com/ether/ep_page_view/blob/master/static/js/page_view.js#L359>, it stopped disappearing but created other issues like generating new <div>s on Up Arrow. Thank you for your time, even if you don't remember. ? Awesome work you did in all those years. ? - You are receiving this because you were assigned. Reply to this email directly, view it on GitHub<#20 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AANewMLylh0ZvtFcRrHrf7nzKyzjl3cSks5swH_6gaJpZM4DgCej>.

[monkey-pawan]

Np.