Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve source entity and managed object attributes by name #301

Merged
merged 2 commits into from
Jan 16, 2019

Conversation

iby
Copy link
Contributor

@iby iby commented Jan 13, 2019

Fixes #300 – see it for details. Also improves the use of whitespace consistency across the CustomSchemaMappingProvider.swift and uses method names for cs_resolve… over cs_resolved… for better alignment with Swift API Design Guidelines.

iby added 2 commits January 13, 2019 05:41
Addresses JohnEstropia#300 – see it for details. Also improves the use of whitespace consistency across the `CustomSchemaMappingProvider.swift` and uses method names for `cs_resolve…` over `cs_resolved…` for better alignment with [Swift API Design Guidelines](https://swift.org/documentation/api-design-guidelines).
Replace deprecated build matrix configurations with newer alternatives.
@iby iby force-pushed the develop branch 3 times, most recently from 0eb9163 to 284f9db Compare January 13, 2019 07:23
@iby iby force-pushed the develop branch 2 times, most recently from ec59f1c to 46ab70b Compare January 13, 2019 08:21
@JohnEstropia
Copy link
Owner

@ianbytchek Oh wow, that makes a lot of sense. Thanks for this!

I'll do some checks for a while and merge it if there's no other issues

@JohnEstropia JohnEstropia merged commit 62e962e into JohnEstropia:develop Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom schema mapping with copyEntity fails with renaming ids
2 participants