Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Done button is not functional #494

Closed
jwall704 opened this issue Sep 19, 2018 · 13 comments
Closed

Done button is not functional #494

jwall704 opened this issue Sep 19, 2018 · 13 comments

Comments

@jwall704
Copy link

Steps:

  1. Launch System Preferences
  2. Select Desktop & Screen Saver
  3. Select Aerial screen saver
  4. Select Screen Saver Options
  5. Make necessary changes
  6. Click Done

Results:
No response when clicking done. Options UI remains in place.

Workaround:
Force Quit System Preferences

@scaraux
Copy link

scaraux commented Sep 19, 2018

Same here
10.14

@glouel
Copy link
Collaborator

glouel commented Sep 24, 2018

See here for a fix in the meantime : #463 (comment)

This was referenced Sep 28, 2018
@glouel
Copy link
Collaborator

glouel commented Sep 28, 2018

@glouel glouel closed this as completed Sep 28, 2018
@joshers2005
Copy link

joshers2005 commented Sep 28, 2018

What happed to New York City, London and San Fransisco?

@glouel
Copy link
Collaborator

glouel commented Sep 28, 2018

Those videos have been replaced by Apple in their JSON with new ones (mostly the Space videos). Best guess, they weren't shot in 4K.

See #463 (comment) for more on that.

@joshers2005
Copy link

Ah, will they ever come back? Those were my favorites. Until then, I am sticking back to the old release.

@glouel
Copy link
Collaborator

glouel commented Sep 28, 2018

Please check the comment I linked about that. Short answer, maybe.

@esetnik
Copy link
Collaborator

esetnik commented Sep 28, 2018

@joshers2005 @glouel I see no reason why we can't merge both new and old lists to create a comprehensive set of all 4k assets. I'm not really concerned with even going as far as hard-coding the asset links instead of downloading a payload from Apple. I don't see what the difference is between hard-coding a payload link and hardcoding the media links. Also this would enable us to open up the UI to allow users to provide their own supplementary media links for any 4k content that's publicly available. We could even accept PRs for known good 4k content from third-party sources if we wanted to. My suggestion would be to create and commit our own manifest.json with a big array of media links that are tagged with the quality, format, description, features, etc.

@glouel
Copy link
Collaborator

glouel commented Sep 28, 2018

@esetnik In that case, those are 1080p only. Cf my linked comment, the tvOS11 JSON (from your branch) only had 2 videos that weren't included already in the tvOS12 JSON we use now.

@esetnik
Copy link
Collaborator

esetnik commented Sep 28, 2018

The idea to dynamically pull the media was based on the concept that apple changes the media list dynamically between tvOS releases. This has not been the case to my knowledge. Instead, each year they have changed the url / file type of the media list leading to breakage and extra work (like untarring). I think it’s better we just create our own list of the assets themselves in the format Aerial best consumes.

@glouel
Copy link
Collaborator

glouel commented Sep 28, 2018

Have you checked this comment I made about exactly all of this ? :
#463 (comment)

@joshers2005
Copy link

Yes. I am primary pissed that over half of the videos got removed. Unless the bugs are doing harm for my iMac's HD, I am keeping the previous version I download yesterday that has all the extra media. I will update the screen saver only when my favorite cities I love come back as I feel the space videos are not as interesting.

@esetnik
Copy link
Collaborator

esetnik commented Sep 28, 2018

Have you checked this comment I made about exactly all of this ? :
#463 (comment)

@glouel perfect!

@esetnik esetnik mentioned this issue Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants