-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Done button is not functional #494
Comments
Same here |
See here for a fix in the meantime : #463 (comment) |
What happed to New York City, London and San Fransisco? |
Those videos have been replaced by Apple in their JSON with new ones (mostly the Space videos). Best guess, they weren't shot in 4K. See #463 (comment) for more on that. |
Ah, will they ever come back? Those were my favorites. Until then, I am sticking back to the old release. |
Please check the comment I linked about that. Short answer, maybe. |
@joshers2005 @glouel I see no reason why we can't merge both new and old lists to create a comprehensive set of all 4k assets. I'm not really concerned with even going as far as hard-coding the asset links instead of downloading a payload from Apple. I don't see what the difference is between hard-coding a payload link and hardcoding the media links. Also this would enable us to open up the UI to allow users to provide their own supplementary media links for any 4k content that's publicly available. We could even accept PRs for known good 4k content from third-party sources if we wanted to. My suggestion would be to create and commit our own manifest.json with a big array of media links that are tagged with the quality, format, description, features, etc. |
@esetnik In that case, those are 1080p only. Cf my linked comment, the tvOS11 JSON (from your branch) only had 2 videos that weren't included already in the tvOS12 JSON we use now. |
The idea to dynamically pull the media was based on the concept that apple changes the media list dynamically between tvOS releases. This has not been the case to my knowledge. Instead, each year they have changed the url / file type of the media list leading to breakage and extra work (like untarring). I think it’s better we just create our own list of the assets themselves in the format Aerial best consumes. |
Have you checked this comment I made about exactly all of this ? : |
Yes. I am primary pissed that over half of the videos got removed. Unless the bugs are doing harm for my iMac's HD, I am keeping the previous version I download yesterday that has all the extra media. I will update the screen saver only when my favorite cities I love come back as I feel the space videos are not as interesting. |
@glouel perfect! |
Steps:
Results:
No response when clicking done. Options UI remains in place.
Workaround:
Force Quit System Preferences
The text was updated successfully, but these errors were encountered: