Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: new aerial screensavers #463

Closed
joshlewis opened this issue Jun 4, 2018 · 45 comments
Closed

Feature request: new aerial screensavers #463

joshlewis opened this issue Jun 4, 2018 · 45 comments

Comments

@joshlewis
Copy link

I hope you'll be doing whatever is necessary to support the new aerial screensavers! I love this screensaver so much!

@MarcelloNicoletti
Copy link

Space would be very nice!

@jarrah31
Copy link

jarrah31 commented Jun 4, 2018

I'd love the new screensavers too, but it looks like this app is no longer being maintained?

@chucker
Copy link

chucker commented Jun 4, 2018

The current JSON manifest doesn't appear to include them yet, so either they haven't actually shipped those videos yet, or the new tvOS release uses a new URL.

@WEZANGO
Copy link

WEZANGO commented Jun 4, 2018

None of 3rd party screensavers seems to work with new Mojave, including this Aerial app.
screen shot 2018-06-05 at 00 13 25

@remus-b
Copy link

remus-b commented Jun 5, 2018

@WEZANGO it writes on the main page of the project about this issue. Try it, maybe it will work. Cheers!

@WEZANGO
Copy link

WEZANGO commented Jun 5, 2018

@remus-b unfortunately no luck. Also tried to delete and reinstall it, but still not working.

@chucker
Copy link

chucker commented Jun 12, 2018

Can anyone confirm tvOS 12 will even fetch the new videos yet? They may not be live at this point.

@bluestarstudios
Copy link

Any updates on this? Would love to see the new ones on here some day! :)

@nicoduj
Copy link

nicoduj commented Sep 19, 2018

I saw the new video yesterday on my ATV, but definitely the url seems to be different since we don't get them in the json files that are in use (neither the one with 4K videos).

@johndpope
Copy link

http://benjaminmayo.co.uk/watch-all-the-apple-tv-aerial-video-screensavers#30047FDA-3AE3-4E74-9575-3520AD77865B
can someone painstakingly create a gist to download all the videos using youtube downloader?

should be

brew install youtubedl

youtubedl  http://youtube.com/link......

@johndpope
Copy link

screen shot 2018-09-19 at 9 44 02 pm

https://sylvan.apple.com/Videos/comp_A114_C001_0305OT_v10_SDR_FINAL_22062018_SDR_2K_AVC.mov

@joshlewis
Copy link
Author

I think what we actually need is the new JSON url from Apple. This is the original one:

http://a1.phobos.apple.com/us/r1000/000/Features/atv/AutumnResources/videos/entries.json

That one doesn't have the new stuff. That's the root of the issue. So what is the new one? Would any little birdies like to tell us? If someone here has an AppleTV and can run its traffic through a VPN you control, you could probably see where it's going to get the list of videos to play.

@nsayer
Copy link

nsayer commented Sep 20, 2018

@joshlewis
Copy link
Author

The page at benjaminmayo.co.uk is using this JSON feed:

http://benjaminmayo.co.uk/scripts/apple-tv-screensavers.json

But that one isn't provided by Apple, and thus might fall out-of-date with the real thing. I presume we won't get an update until we have the actual Apple feed's new URL.

So, hey @benjaminmayo, what's the new URL?

@benjaminmayo
Copy link

The format changed somewhat; you need to extract the JSON out of here https://sylvan.apple.com/Aerials/resources.tar. The JSON includes the URLs to the videos and the time markers for the tvOS 12 captions as a dictionary, keyed by time. The values of this dictionary are keys which can be found in the strings plists.

@glouel
Copy link
Collaborator

glouel commented Sep 20, 2018

For those who would like to test it, I made a quick fork that parses the new files, it plays the 4K-SDR videos by default. Build here :
https://github.com/glouel/Aerial/releases/download/1.4a2/Aerial.saver.zip
(edit with a new build, based on @esetnik 4k branch that included other fixes)

@johnnyblair
Copy link

Thanks seems to be working, with the exception of the "Done" button.

@glouel
Copy link
Collaborator

glouel commented Sep 20, 2018

Yes the Done button seems to be a Mojave issue, happened also with previous versions. I'll try to have a look tomorrow but not sure what happens there. See
#494 (comment)

@glouel
Copy link
Collaborator

glouel commented Sep 22, 2018

I investigated the Done button a bit but couldn't find anything particular, I assume it's another bug linked to Swift screensavers in Mojave, I'll try submitting a radar next week with a small sample project.

In the meantime, pushed a new version with a few features :

  • 1080p and 4K support (you can switch in cache panel)
  • optional video description displayed (bottom left of the screen at video start
  • tweaked the path selector's color for dark mode in cache panel (was barely readable)

Build here : https://github.com/glouel/Aerial/releases/download/1.4b5/Aerial.saver.zip

@JonoHaysom
Copy link

I investigated the Done button a bit but couldn't find anything particular, I assume it's another bug linked to Swift screensavers in Mojave, I'll try submitting a radar next week with a small sample project.

In the meantime, pushed a new version with a few features :

  • 1080p and 4K support (you can switch in cache panel)
  • optional video description displayed (bottom left of the screen at video start
  • tweaked the path selector's color for dark mode in cache panel (was barely readable)

Build here : https://github.com/glouel/Aerial/releases/download/1.4b5/Aerial.saver.zip

Awesome stuff! the new videos work perfectly for me. thanks for work you've put into this

@glouel
Copy link
Collaborator

glouel commented Sep 24, 2018

Hopefully we'll be able to merge changes when @JohnCoates names some extra mainteners. In the meantime, one last build, finally found the issue with the "Done" button not closing on Mojave.

I ended up browsing all swift screensavers on github, found the answer on this project https://github.com/burnsra/SilhouetteSaver (which ironically doesn't work on Mojave) with an alternate way to dismiss the sheet 🎉

Build here :
https://github.com/glouel/Aerial/releases/download/1.4b6/Aerial.saver.zip

@jarrah31
Copy link

Thank you very much @glouel for the work you've put into this - the earth from space video looks amazing on my MacBook!

@nicoduj
Copy link

nicoduj commented Sep 24, 2018

great job @glouel !

@rochev22
Copy link

@glouel thanks for your update!!!

@jstr
Copy link

jstr commented Sep 25, 2018

@glouel when I try your latest release on Mojave I get a warning "You cannot use the Aerial screen saver on this version of macOS. Please contact the vendor to get a newer version of the screen saver." Any ideas?

Edit: Nevermind, tracked it down to #487

@glouel
Copy link
Collaborator

glouel commented Sep 25, 2018

@glouel when I try your latest release on Mojave I get a warning "You cannot use the Aerial screen saver on this version of macOS. Please contact the vendor to get a newer version of the screen saver." Any ideas?

Edit: Nevermind, tracked it down to #487

To be clear, does it work for you now ? It should work on the latest builds of Mojave. If not check the last paragraph on the project description for a workaround : https://github.com/JohnCoates/Aerial

@glouel
Copy link
Collaborator

glouel commented Sep 25, 2018

So I'm putting one more beta here. This one addresses a couple of things, and is mostly for those who have Macs older than Late 2015 (see
#505 ). If you install it on top of a previous beta, please go into Cache and set your Video Format to the one you wish to use to avoid redownloading videos. I set the default to 1080p H264 (the most compatible one). There's a help button with more info on what to use.

capture d ecran 2018-09-25 a 18 00 42

Build here :
https://github.com/glouel/Aerial/releases/download/1.4b7/Aerial.saver.zip

@jridder
Copy link

jridder commented Sep 25, 2018

The Done button works in 1.4b7!!

@quavoce
Copy link

quavoce commented Sep 26, 2018

@glouel Feature request - would it be possible to optionally allow the video description to remain showing rather than fading off after a few seconds please? I often miss the start of the videos but would still like to know where each location is.
Thanks!

@glouel
Copy link
Collaborator

glouel commented Sep 26, 2018

@glouel Feature request - would it be possible to optionally allow the video description to remain showing rather than fading off after a few seconds please? I often miss the start of the videos but would still like to know where each location is.
Thanks!

There you go :

capture d ecran 2018-09-26 a 14 29 08

https://github.com/glouel/Aerial/releases/download/1.4b8/Aerial.saver.zip

@quavoce
Copy link

quavoce commented Sep 26, 2018

Superb!!! Thank you very much @glouel !!

Lots of work colleagues keep gawking at these amazing aerial videos on my laptop (especially the earth ones), and it's thanks to your efforts they work really well with no more bugs on my Mojave build. I really like the ability to display a different video on each screen too! It's all very distracting so really must get back to doing actual work. :)

@brainguynyc
Copy link

Sorry but I don't have the "always" option next to "show descriptions" :-(

@glouel
Copy link
Collaborator

glouel commented Sep 26, 2018

Hehe thanks @quavoce ;) I really enjoy those space videos so it was fun adding them back !

There are still a few things that needs to be addressed, hopefully we can put some roadmap and better track bugs after we get a new maintainer.

Some random thoughts about my implementation :

  • In order to add H264, there's one Honk Kong video that is now ignored. This particular video isn't available in H264 in the JSON, only in HEVC, and because of the internals of the video list, I had to remove it for everyone (can't have a video missing for one format).
  • I have a branch that brings back tvOS11 4K screensavers. Sad thing is, and I should have checked before... they are nearly all in the tvOS12 JSON already 😅 There's one desert video (and I don't remember the other one) that aren't included in the tvOS12 JSON. Because it was a quick hack and it didn't bring much, I didn't push that branch. If the video list gets fixed (see above), we could also add back the tvOS10 videos (the originals). Those are 1080p H264 only though.
  • I'm pretty sure that even on my Late 2015 iMac 5K (Intel Skylake with AMD GPU), AVKit uses Intel's iGPU fixed function hw decoding (aka QuickSync) for H264, as I saw this on the console :
    GVA info: Successfully connected to the Intel plugin, offline Gen9
    I assume it is also used for HEVC too in my case (although I didn't see any such message on console).
  • Some discrete AMD GPUs also have H.264 and HEVC decoding, but not all of them. In my case (M2XX, Tonga), that generation only has UVD 5.0 with H.264 hw decoding, but not HEVC. HEVC came with Polaris (the 400/500 series on laptops).
  • Knowing what gets used will probably be pretty important in order to track bugs/crashes in the future (see Video freezes after playing normally for a variable period of time #468 which I couldn't reproduce after a few hours of playback on my very old Sandy Bridge 2011 Macbook Air). I don't know if we can know either what is available, or what is used through an API, or if we'll have to do guesswork. Some interesting cases would be the iMac Pro (no IGP, but modern AMD GPU with H.264/HEVC decoding, which I assume is used there) or the old Mac Pros (no IGP, probably only H.264 decoding ?).
  • I'm pretty sure we're streaming when we shouldn't, probably on the control panel. There were a few issues raised about that, I think some cleanup around that is needed. I also added a (hidden/non implemented) checkbox to disable all streaming.
  • Full Offline mode should be easy to add, but will need some serious rejiggering of the manifestloader though.
  • A priority imo should be to stop downloading the tar/JSON all the time. We should check it weekly/monthly at best (we can give the choice through a pref).
  • A fade in/out for videos would be coo tool, someone had a patch but ran into some issues, mostly because in order to implement the fade out, you need accurate duration for the video. This is the kind of thing that may have been fixed in later versions of AVKit/MacOS and will need to be investigated more.
  • We talked with @esetnik about what would be needed for bringing back day/night, and show day/night videos depending on current time (a bit like the dynamic wallpapers on Mojave). That will probably come later though.

@glouel
Copy link
Collaborator

glouel commented Sep 26, 2018

Sorry but I don't have the "always" option next to "show descriptions" :-(

It's in beta 8 :
https://github.com/glouel/Aerial/releases/download/1.4b8/Aerial.saver.zip

@brainguynyc
Copy link

Sorry but I don't have the "always" option next to "show descriptions" :-(

It's in beta 8 :
https://github.com/glouel/Aerial/releases/download/1.4b8/Aerial.saver.zip

Reloaded and voila! Have the option now!

@standishogrady
Copy link

Thanks for the updates, the new space aerials are great.

@max1mvs
Copy link

max1mvs commented Sep 27, 2018

Great job guys! And thank you so much for your work @glouel – on my Mac it works impeccably. Wow. So great a screensaver to have. I can't fathom why Apple hasn't made this standard on MacOS…

@vichudson1
Copy link

I'm running the new 1.4b8 version and it looks great! Thanks Guys! I did have a thought. I'm a little concerned about enabling the location display to always as it fixes it into the lower corner all the time. It should be changed frequently enough to prevent any burn in I suppose, but to be safe and for aesthetic reasons has anyone considered styling the location display like the floating clock and having it drift around too?

@esetnik
Copy link
Collaborator

esetnik commented Sep 27, 2018

@vichudson1 that's a really good point considering this is after all a "screen saver" and shouldn't by definition be causing any additional burn in or uneven wear.

@glouel
Copy link
Collaborator

glouel commented Sep 27, 2018

Ideally, there's a string bundle with the extra descriptions that are shown on the Apple TV. That's one thing I didn't put on my big post up there, it would be a "nice to have" to be able to display those (there's a timecode and a string to be displayed at specific times). I haven't looked into it yet.

Moving the description in the meantime sounds good to me. Maybe something "subtle" like moving from one corner to another every minute or so ?

Side note, starting with 10.13, we can detect if HEVC/H.264 hw acceleration is available, but it doesn't give any detail on the method used. Still better than nothing.

(Edit: still a bit of work but I got the basic localized string thing working. I'll try to have a beta for it soon)

@quavoce
Copy link

quavoce commented Sep 28, 2018

  • I have a branch that brings back tvOS11 4K screensavers. Sad thing is, and I should have checked before... they are nearly all in the tvOS12 JSON already 😅 There's one desert video (and I don't remember the other one) that aren't included in the tvOS12 JSON. Because it was a quick hack and it didn't bring much, I didn't push that branch. If the video list gets fixed (see above), we could also add back the tvOS10 videos (the originals). Those are 1080p H264 only though.

I'm missing those early screensavers now... (London / the one that flies from the sea to a green valley / SF bridge / etc). Here's hoping you're able to work out a way to include those back in as well please. :)

This was referenced Sep 28, 2018
@glouel
Copy link
Collaborator

glouel commented Sep 28, 2018

Thanks to @JohnCoates I pushed the latest build in this repository, you can find it in the releases. Only difference with my own 1.4beta9 build is that this one is signed, should be easier for everyone 🎉

@glouel glouel closed this as completed Sep 28, 2018
@esetnik esetnik mentioned this issue Sep 28, 2018
@glouel
Copy link
Collaborator

glouel commented Sep 29, 2018

If you have a minute check this issue for a test version with the extended descriptions for the space videos :
#512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests