Skip to content
This repository has been archived by the owner on Oct 22, 2019. It is now read-only.

Allow passing already configured redis client to the storage adapter #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bdudelsack
Copy link

No description provided.

@bracki
Copy link
Contributor

bracki commented Sep 21, 2016

What's the benefit of reuse here?

@bdudelsack
Copy link
Author

In my application i already have configured Redis instance, so i don't need to make another one at the point of prometheus client creation.

Actually i think that redis configuration should be taken out of the library and the end user should instantiate it by himself because it out of scope of the lib.

@bracki bracki mentioned this pull request Mar 19, 2018
@NoelDavies
Copy link

This project is dead, but I'm maintaining it under my employer - https://github.com/endclothing/prometheus_client_php. Feel free to submit the PR there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants