Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): add Websocket support to the Outline Client config #2351

Merged
merged 11 commits into from
Jan 31, 2025
Merged

feat(client): add Websocket support to the Outline Client config #2351

merged 11 commits into from
Jan 31, 2025

Conversation

fortuna
Copy link
Collaborator

@fortuna fortuna commented Jan 30, 2025 •
edited
Loading

This enables websocket in the Outline Client, at last!

Resolves #2272

@fortuna fortuna requested review from a team as code owners January 30, 2025 17:16
@fortuna fortuna requested a review from sbruens January 30, 2025 17:16
@fortuna fortuna changed the title feat(client): Add Websocket support to the Outline Client config feat(client): add Websocket support to the Outline Client config Jan 30, 2025
@fortuna fortuna mentioned this pull request Jan 29, 2025
Closed
sbruens
sbruens approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@sbruens sbruens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, so clean! Should we update the config.md documentation?

@github-actions github-actions bot added size/M and removed size/S labels Jan 30, 2025
@fortuna
Copy link
Collaborator Author

fortuna commented Jan 30, 2025

Depends on Jigsaw-Code/outline-sdk#368

@fortuna
Copy link
Collaborator Author

fortuna commented Jan 30, 2025

I also updated the config documentation.

fortuna
fortuna commented Jan 31, 2025
View reviewed changes
Copy link
Collaborator Author

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with the use of endpoint. Now it's easy to override it to bypass dns blocking.

Please take another look

@fortuna fortuna requested a review from sbruens January 31, 2025 14:43
@fortuna fortuna enabled auto-merge (squash) January 31, 2025 16:40
@fortuna fortuna disabled auto-merge January 31, 2025 16:40
@fortuna fortuna merged commit 946132d into master Jan 31, 2025
25 checks passed
@fortuna fortuna deleted the fortuna-ws branch January 31, 2025 16:42
daniellacosse pushed a commit that referenced this pull request Feb 20, 2025
@fortuna @daniellacosse
feat(client): add Websocket support to the Outline Client config (#2351)
ea592dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbruens sbruens sbruens approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Websocket endpoints
3 participants
@fortuna @sbruens @daniellacosse