Fix crash when creating SwingRedrawer on DirectX #917
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Throw
RenderException
when constructingDirect3DSwingRedrawer
withnullptr
device. (Similar toDirect3DRedrawer
)To avoid crash in:
Fixes
Speculative fix for crash with a stack head below:
Note
I've found suspicious place in
Seems like
redrawer
is disposed twice ifredrawerFactory
throws (both paths constructingRedrawerManager
are affected).@igordmn can you have a look?
It's a universal path for all desktop users, so I wonder why it didn't backfire, if it's indeed incorrect.
May be it's because we don't really call
redrawerFactory
if a redrawer was constructed correctly, so disposal of old one doesn't ever get called in this context. I'm not sure where are the invariant boundaries here.