Build Skiko with Clang-CL #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alovchin91
force-pushed
the
alovchin/clang-cl
branch
from
fc06646 to
4994bc5
Compare
|
The CI is failing because this PR depends on a new Skia-pack release (-2). |
Alovchin91
commented
Feb 5, 2025
skiko/src/commonMain/kotlin/org/jetbrains/skia/BreakIterator.kt
Outdated
Show resolved
Hide resolved
Alovchin91
force-pushed
the
alovchin/clang-cl
branch
from
9b63fd3 to
3471a22
Compare
igordmn
approved these changes
Feb 7, 2025
skiko/src/commonMain/kotlin/org/jetbrains/skia/BreakIterator.kt
Outdated
Show resolved
Hide resolved
|
|
igordmn
reviewed
Feb 7, 2025
Alovchin91
force-pushed
the
alovchin/clang-cl
branch
from
2452284 to
d8aa60a
Compare
|
Binary size 27 % is smaller |
Alovchin91
force-pushed
the
alovchin/clang-cl
branch
from
d8aa60a to
d03c5c5
Compare
Schahen
requested changes
Feb 11, 2025
Alovchin91
force-pushed
the
alovchin/clang-cl
branch
from
d03c5c5 to
a63fcf0
Compare
I've split the BreakIterator part off into a separate PR: #1024 It would be a prerequisite for this one. |
Alovchin91
force-pushed
the
alovchin/clang-cl
branch
2 times, most recently
from
eed7433 to
9e3d428
Compare
MatkovIvan
reviewed
Feb 11, 2025
MatkovIvan
pushed a commit
that referenced
this pull request
Feb 11, 2025
This PR is split-off from and is a prerequisite of Clang-cl PR: #1020 BreakIterator.clone() is broken on JVM and seemingly leads to a use-after-free behaviour. Clang-cl makes this issue more visible, likely due to address sanitisation. Explanation why it is deleted in an internal channel: https://jetbrains.slack.com/archives/C02DDNREC77/p1738678000232729 * `breakIteratorCloneTest` is failing with an access violation in Debug mode with additional checks, so using it wasn't safe * it is not used anywhere This is a breaking change and will require bumping Skiko version to 0.9.0.
Alovchin91
force-pushed
the
alovchin/clang-cl
branch
from
9e3d428 to
e3464bc
Compare
MatkovIvan
approved these changes
Feb 11, 2025
igordmn
approved these changes
Feb 12, 2025
Schahen
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Official Skia documentation suggests that it's highly recommended to build Skia with Clang-CL on Windows, and that this dramatically improves Skia performance with Software rendering and in other areas. This corresponds with my experience, so here it is.
Related Skia-pack PR: JetBrains/skia-pack#64
Prerequisite: #1024