Fix of NoClassDefFoundError due to unintended Lincheck analysis of StackTraceElement methods
#423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment` classes Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
ndkoval
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #376
It implements a quick bug fix specifically for #376, but does not completely solve the root problem described in #419.
This problem in general is more ubiquitous, requires more complicated changes, and thus would be addressed by a separate PR.
The fix implemented in this PR wraps all methods from
java.lang.StackTraceElementclass into ignored sections.This is required due to a combination of two reasons:
StackTraceElementown bytecode is not analyzed, but it can call methods fromjava.util(e.g.,HashMap), which are analyzed by the Lincheck.StackTraceElementmethods can be called almost from any point during execution (e.g., they are called when an exeption is thrown and its stack trace is being collected).Thus, in order to ensure that
StackTraceElementcode is not analyzed by the Lincheck, we need to wrap its methods into an ignored section.