-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect atomic primitive method calls dynamically #336
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
ndkoval
requested changes
Jun 28, 2024
...jvm/main/org/jetbrains/kotlinx/lincheck/transformation/transformers/MethodCallTransformer.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/util/AtomicMethods.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
ndkoval
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have two injection methods to handle method calls:
beforeMethodCall
andbeforeAtomicMethodCall
.This solution has several problems:
Code duplication.
We do not handle classes inheriting from
Atomic*
classes propertly, because their methods are not detected as "atomic" statically by theMethodCallTransformer
bytecode transformer that injectsbeforeMethodCall
andbeforeAtomicMethodCall
invocations. This is because this transformer decides what method to insert statically based on the class name of the invoked method. It checks only forj.u.c.Atomic*
method names, and do not handles subclasses of atomics.This PR removes
beforeAtomicMethodCall
injection, letting the managed strategy to decide how to handle the method dynamically at runtime, based on the actual type of the method receiver.I've also added a new test
AtomicSubclassTest.kt
checking that subclasses ofAtomic*
classes are properly supported.Please note, that with this PR the memory access methods of
Atomic*
,Atomic*FieldUpdater
,VarHandle
andUnsafe
APIs are treated as atomic. Therefore, this PR also closes #288.The latter also implies that
Atomic*Array::length()
method is no longer considered to be atomic method.Because of this, it has disappeared from the trace output of some tests.