Libtest tests fixed #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndkoval
requested changes
Oct 24, 2019
There was a problem hiding this comment.
- Please, take a look at the related review comments in Managed strategies #5.
- It would be better to know failure reasons and use them instead of
shouldFail=true.
ndkoval
requested changes
Nov 5, 2019
libtest/src/main/java/org/jetbrains/kotlinx/lincheck/tests/custom/counter/Counters.kt
Outdated
Show resolved
Hide resolved
libtest/src/main/java/org/jetbrains/kotlinx/lincheck/tests/custom/transfer/Accounts.java
Outdated
Show resolved
Hide resolved
libtest/src/test/java/org/jetbrains/kotlinx/lincheck/AnalyzeAccessor.kt
Outdated
Show resolved
Hide resolved
libtest/src/test/java/org/jetbrains/kotlinx/lincheck/tests/AbstractLinCheckTest.kt
Outdated
Show resolved
Hide resolved
libtest/src/test/java/org/jetbrains/kotlinx/lincheck/tests/LockFreeDequeTest.kt
Outdated
Show resolved
Hide resolved
lincheck/src/main/java/org/jetbrains/kotlinx/lincheck/TestReport.kt
Outdated
Show resolved
Hide resolved
lincheck/src/main/java/org/jetbrains/kotlinx/lincheck/TestReport.kt
Outdated
Show resolved
Hide resolved
lincheck/src/main/java/org/jetbrains/kotlinx/lincheck/TestReport.kt
Outdated
Show resolved
Hide resolved
lincheck/src/test/java/org/jetbrains/kotlinx/lincheck/test/AlmostEmptyScenarioTest.kt
Outdated
Show resolved
Hide resolved
lincheck/src/main/java/org/jetbrains/kotlinx/lincheck/strategy/ManagedStrategy.java
Outdated
Show resolved
Hide resolved
ndkoval
requested changes
Nov 7, 2019
libtest/src/test/java/org/jetbrains/kotlinx/lincheck/tests/custom/deadlock/DeadLockTest.kt
Outdated
Show resolved
Hide resolved
...src/main/java/org/jetbrains/kotlinx/lincheck/strategy/randomswitch/RandomSwitchStrategy.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/jetbrains/kotlinx/lincheck/strategy/randomswitch/RandomSwitchStrategy.java
Outdated
Show resolved
Hide resolved
...st/java/org/jetbrains/kotlinx/lincheck/test/runner/ParallelThreadsRunnerEasyExceptionTest.kt
Outdated
Show resolved
Hide resolved
lincheck/src/main/java/org/jetbrains/kotlinx/lincheck/strategy/IterationResult.kt
Outdated
Show resolved
Hide resolved
lincheck/src/main/java/org/jetbrains/kotlinx/lincheck/strategy/IterationResult.kt
Outdated
Show resolved
Hide resolved
lincheck/src/main/java/org/jetbrains/kotlinx/lincheck/strategy/Strategy.java
Outdated
Show resolved
Hide resolved
lincheck/src/main/java/org/jetbrains/kotlinx/lincheck/LinChecker.java
Outdated
Show resolved
Hide resolved
libtest/src/test/java/org/jetbrains/kotlinx/lincheck/tests/AbstractLinCheckTest.kt
Outdated
Show resolved
Hide resolved
libtest/src/test/java/org/jetbrains/kotlinx/lincheck/AnalyzeAccessor.kt
Outdated
Show resolved
Hide resolved
alefedor
force-pushed
the
test-fix
branch
4 times, most recently
from
8dad43d to
1da1802
Compare
ndkoval
force-pushed
the
test-fix
branch
2 times, most recently
from
e5af238 to
688b829
Compare
* Remove `libtest` module but keep some of the tests from it * Make the project a single-module one * Add `AbstractLincheckTest` abstraction to manage most of the tests in a single place and write them easier * Rewrite some of the code into Kotlin * Reuse verifiers properly * Handle deadlocks/livelocks and unexpected exceptions properly * etc
ndkoval
requested review from
SokolovaMaria
and removed request for
SokolovaMaria
|
The changes were moved to #35, thanks for the cleaning up the code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a problem with not all tests being executed.
Improved tests.
Added
AbstractLinCheckTestfor testing all LinCheck strategies