Add second set of components #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsmb13
force-pushed
the
components-2
branch
2 times, most recently
from
0fa2a83 to
08c59e4
Compare
zsmb13
force-pushed
the
components-2
branch
2 times, most recently
from
155335f to
8fb49b7
Compare
zsmb13
commented
Nov 18, 2024
|
|
||
| AnimatedVisibility(enabled) { | ||
| Icon( | ||
| // TODO review icon sizing later |
There was a problem hiding this comment.
We'll need to take a look at the exact icon resources we have imported. We currently have them in 16, 24, 28 size variants, but I suspect we might not need all of these (as they're vectors anyway).
There was a problem hiding this comment.
It depends on the vector export properties (sometimes line width can scale badly)
e5l
approved these changes
Nov 19, 2024
|
|
||
| AnimatedVisibility(enabled) { | ||
| Icon( | ||
| // TODO review icon sizing later |
There was a problem hiding this comment.
It depends on the vector export properties (sometimes line width can scale badly)
ui-components/src/commonMain/kotlin/org/jetbrains/kotlinconf/ui/components/TopMenuButton.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-11-16.at.0.00.30.mov
Screen.Recording.2024-11-16.at.0.01.10.mov