Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indeterminate state not working in Checkboxes #705

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

rock3r
Copy link
Collaborator

@rock3r rock3r commented Nov 27, 2024

The issue was that we weren't considering indeterminate as selected, icon-wise, but the IDE resources do consider it as such.

The issue was that we weren't considering indeterminate as selected,
icon-wise, but the IDE resources do consider it as such.
@rock3r rock3r added the bug Something isn't working label Nov 27, 2024
@rock3r rock3r requested a review from hamen November 27, 2024 10:15
@rock3r rock3r self-assigned this Nov 27, 2024
@rock3r rock3r enabled auto-merge (squash) November 27, 2024 10:15
Same issue as the previous commit: indeterminate looks and behaves like
selected, but it wasn't treated as such.
Copy link
Collaborator

@hamen hamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@rock3r rock3r merged commit f1900e1 into main Nov 27, 2024
1 check passed
@rock3r rock3r deleted the fix-checkbox-indeterminate-state branch November 27, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants