Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework SelectableLazyColumn #620

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Rework SelectableLazyColumn #620

merged 5 commits into from
Sep 30, 2024

Conversation

hamen
Copy link
Collaborator

@hamen hamen commented Sep 30, 2024

  • Existing org.jetbrains.jewel.foundation.lazy.SelectableLazyColumn has been renamed to org.jetbrains.jewel.foundation.lazy.BasicSelectableLazyColumn
  • A new org.jetbrains.jewel.ui.component.SelectableLazyColumn has been created. It exposes the same API for now, simply acting as a pass-through
  • Old usages of SelectableLazyColumn have been updated to use the new version.

@rock3r
Copy link
Collaborator

rock3r commented Sep 30, 2024

Related: this is the first step for #158

@rock3r rock3r self-requested a review September 30, 2024 16:15
Signed-off-by: Ivan Morgillo <[email protected]>
@rock3r rock3r added the api Changes related to the public API label Sep 30, 2024
@hamen hamen marked this pull request as ready for review September 30, 2024 16:51
Signed-off-by: Ivan Morgillo <[email protected]>
@rock3r rock3r enabled auto-merge (squash) September 30, 2024 17:55
@rock3r rock3r merged commit 75d4570 into main Sep 30, 2024
1 check passed
@rock3r rock3r deleted the im-rename-SLC branch September 30, 2024 18:34
hamen added a commit that referenced this pull request Oct 21, 2024
hamen added a commit that referenced this pull request Oct 21, 2024
rock3r pushed a commit that referenced this pull request Oct 21, 2024
Revert "Rework SelectableLazyColumn (#620)"

This reverts commit 75d4570.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Changes related to the public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants