failed test line highlighting: warning by default

JetBrains · May 14, 2018 · 6fb72d0 · 6fb72d0
1 parent d898da8
commit 6fb72d0
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 9 deletions.
diff --git a/java/execution/impl/src/com/intellij/execution/testframework/TestFailedLineInspection.java b/java/execution/impl/src/com/intellij/execution/testframework/TestFailedLineInspection.java
@@ -37,8 +37,8 @@ public void visitMethodCallExpression(PsiMethodCallExpression call) {
           new RunActionFix(call, DefaultRunExecutor.EXECUTOR_ID)};
         ProblemDescriptor descriptor = InspectionManager.getInstance(call.getProject())
                                                         .createProblemDescriptor(call, state.errorMessage, isOnTheFly, fixes,
-                                                                                 ProblemHighlightType.GENERIC_ERROR);
-        descriptor.setTextAttributes(CodeInsightColors.RUNTIME_PROBLEM);
+                                                                                 ProblemHighlightType.GENERIC_ERROR_OR_WARNING);
+        descriptor.setTextAttributes(CodeInsightColors.RUNTIME_ERROR);
         holder.registerProblem(descriptor);
       }
     };

diff --git a/java/java-impl/src/META-INF/JavaPlugin.xml b/java/java-impl/src/META-INF/JavaPlugin.xml
@@ -201,7 +201,7 @@
                               implementationClass="com.intellij.testIntegration.TestRunLineMarkerProvider"/>
     <projectService serviceImplementation="com.intellij.testIntegration.TestFailedLineManager"/>
     <localInspection groupPath="Java" language="JAVA" shortName="TestFailedLine"
-                     enabledByDefault="true" level="ERROR"
+                     enabledByDefault="true" level="WARNING"
                      groupBundle="messages.InspectionsBundle" groupKey="group.names.junit.issues"
                      displayName="Highlight problem line in test"
                      implementationClass="com.intellij.execution.testframework.TestFailedLineInspection"/>

diff --git a/platform/core-api/src/com/intellij/openapi/editor/colors/CodeInsightColors.java b/platform/core-api/src/com/intellij/openapi/editor/colors/CodeInsightColors.java
@@ -22,7 +22,7 @@ public interface CodeInsightColors {
   TextAttributesKey WARNINGS_ATTRIBUTES = TextAttributesKey.createTextAttributesKey("WARNING_ATTRIBUTES");
   TextAttributesKey GENERIC_SERVER_ERROR_OR_WARNING = TextAttributesKey.createTextAttributesKey("GENERIC_SERVER_ERROR_OR_WARNING");
   TextAttributesKey DUPLICATE_FROM_SERVER = TextAttributesKey.createTextAttributesKey("DUPLICATE_FROM_SERVER");
-  TextAttributesKey RUNTIME_PROBLEM = TextAttributesKey.createTextAttributesKey("RUNTIME_PROBLEM");
+  TextAttributesKey RUNTIME_ERROR = TextAttributesKey.createTextAttributesKey("RUNTIME_ERROR");
   /**
    * use #WEAK_WARNING_ATTRIBUTES instead
    */

diff --git a/platform/lang-impl/src/com/intellij/application/options/colors/ColorSettingsUtil.java b/platform/lang-impl/src/com/intellij/application/options/colors/ColorSettingsUtil.java
@@ -77,7 +77,7 @@ private static void addInspectionSeverityAttributes(List<AttributesDescriptor> d
     descriptors.add(new AttributesDescriptor(OptionsBundle.message("options.java.attribute.descriptor.weak.warning"), CodeInsightColors.WEAK_WARNING_ATTRIBUTES));
     descriptors.add(new AttributesDescriptor(OptionsBundle.message("options.java.attribute.descriptor.server.problems"), CodeInsightColors.GENERIC_SERVER_ERROR_OR_WARNING));
     descriptors.add(new AttributesDescriptor(OptionsBundle.message("options.java.attribute.descriptor.server.duplicate"), CodeInsightColors.DUPLICATE_FROM_SERVER));
-    descriptors.add(new AttributesDescriptor(OptionsBundle.message("options.java.attribute.descriptor.runtime"), CodeInsightColors.RUNTIME_PROBLEM));
+    descriptors.add(new AttributesDescriptor(OptionsBundle.message("options.java.attribute.descriptor.runtime"), CodeInsightColors.RUNTIME_ERROR));
 
     for (SeveritiesProvider provider : Extensions.getExtensions(SeveritiesProvider.EP_NAME)) {
       for (HighlightInfoType highlightInfoType : provider.getSeveritiesHighlightInfoTypes()) {

diff --git a/platform/lang-impl/src/com/intellij/openapi/options/colors/pages/GeneralColorsPage.java b/platform/lang-impl/src/com/intellij/openapi/options/colors/pages/GeneralColorsPage.java
@@ -65,6 +65,7 @@ public class GeneralColorsPage implements ColorSettingsPage, InspectionColorSett
     "  <for_removal>Deprecated symbol marked for removal</for_removal>\n" +
     "  <unused>Unused symbol</unused>\n"+
     "  <wrong_ref>Unknown symbol</wrong_ref>\n" +
+    "  <runtime_error>Runtime problem</runtime_error>\n" +
     "  <server_error>Problem from server</server_error>\n" +
     "  <server_duplicate>Duplicate from server</server_duplicate>\n" +
     getCustomSeveritiesDemoText();
@@ -168,6 +169,7 @@ public class GeneralColorsPage implements ColorSettingsPage, InspectionColorSett
     ADDITIONAL_HIGHLIGHT_DESCRIPTORS.put("weak_warning", CodeInsightColors.WEAK_WARNING_ATTRIBUTES);
     ADDITIONAL_HIGHLIGHT_DESCRIPTORS.put("server_error", CodeInsightColors.GENERIC_SERVER_ERROR_OR_WARNING);
     ADDITIONAL_HIGHLIGHT_DESCRIPTORS.put("server_duplicate", CodeInsightColors.DUPLICATE_FROM_SERVER);
+    ADDITIONAL_HIGHLIGHT_DESCRIPTORS.put("runtime_error", CodeInsightColors.RUNTIME_ERROR);
     for (SeveritiesProvider provider : Extensions.getExtensions(SeveritiesProvider.EP_NAME)) {
       for (HighlightInfoType highlightInfoType : provider.getSeveritiesHighlightInfoTypes()) {
         ADDITIONAL_HIGHLIGHT_DESCRIPTORS.put(getHighlightDescTagName(highlightInfoType),

diff --git a/platform/platform-resources/src/DefaultColorSchemesManager.xml b/platform/platform-resources/src/DefaultColorSchemesManager.xml
@@ -296,9 +296,9 @@
           <option name="ERROR_STRIPE_COLOR" value="cf5b56" deuteranopia="d95716" protanopia="d95716"/>
         </value>
       </option>
-      <option name="RUNTIME_PROBLEM">
+      <option name="RUNTIME_ERROR">
         <value>
-          <option name="EFFECT_COLOR" value="ff0000" />
+          <option name="EFFECT_COLOR" value="f49810" />
           <option name="ERROR_STRIPE_COLOR" value="cf5b56" />
           <option name="EFFECT_TYPE" value="5" />
         </value>
@@ -1600,9 +1600,9 @@
           <option name="ERROR_STRIPE_COLOR" value="9e2927" deuteranopia="ff8f40" protanopia="ff8f40"/>
         </value>
       </option>
-      <option name="RUNTIME_PROBLEM">
+      <option name="RUNTIME_ERROR">
         <value>
-          <option name="EFFECT_COLOR" value="bc3f3c"/>
+          <option name="EFFECT_COLOR" value="f49810"/>
           <option name="EFFECT_TYPE" value="5" />
           <option name="ERROR_STRIPE_COLOR" value="9e2927"/>
         </value>