Bug is back: Popup saying that ignored files are in .gitignore

[svenbergryen]

Prerequisites

• Plugin is in the latest version
• Issue was not reported yet
• Stack trace (if provided) contains mobi.hsz.idea.gitignore package name

Description

Whenever I open a project, there's a message saying <<Ignored files found that are tracked: .ignore plugin found some files that are tracked with Git which are also listed in .gitignore file>>

Steps to Reproduce

1. Open a PHPStorm project

Expected behavior:
I expected the popup to appear only when appropriate and list the files that are tracked and in .gitignor

Actual behavior:
Empty dialog opens.

Reproduces how often:
Every time

Versions

Plugin:
2.2.2

IDE:
PhpStorm 2017.3 EAP
Build #PS-173.3188.26, built on October 11, 2017
PhpStorm EAP User
Expiration date: November 10, 2017
JRE: 1.8.0_152-release-1024-b5 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Mac OS X 10.13.1

OS:
10.13.1

Additional Information

[svenbergryen]

This bug was recently fixed in #400 and is now back in 2.2.2

[kha1989led]

I'm getting that same behavior every time I open my project (which takes me to the empty dialog):

Plugin version:

Intellij Idea version:

[hsz]

@svenbergryen Thank you for this report. Issue was very weird and related to the IntelliJ API:
ConcurrentWeakHashMap map object was randomly cleared.

I've also changed the popup type from warning to information.

[daneah]

@hsz I recently updated to 2.3.0 and still see this issue in PyCharm.

[hsz]

@daneah You mean that still empty dialog is displayed?

[daneah]

@hsz that's correct:

[pbienick]

Same here - it's coming up again for all of my projects. IDEA 2017.2.5, .ignore 2.3.0

[jpmschuler]

Confirmed, .ignore 2.3.0 PHPStorm 2017.2.4

[Jean85]

Confirmed, .ignore 2.3.0 PHPStorm 2017.2.4

Same here

[daneah]

This bug still appears as of PyCharm 2018.1 and the latest version of this plugin.

[karfau]

Same here:

IntelliJ IDEA 2018.2.3 (Ultimate Edition)
Build #IU-182.4323.46, built on September 3, 2018
JRE: 1.8.0_152-release-1248-b8 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Linux 4.14.68-1-MANJARO

[borysboyko]

I am also seeing this issue.

[karfau]

I consider this bug a major thing, since the longer it is not fixed the more will people get used to ignoring this popup until it renders the plugin useless...
Is there anything we can do to support a fix for this?
I'm willing to spend money for getting this fixed.
Let's be more precise: 20 EUR from me via paypal for whoever fixes this bug.

[hsz]

This feature will be disabled with v3.1.0

[karfau]

I would love to understand your decision.

[hsz]

@karfau Sure, this popup was generating a false-positives in many cases and - as you mentioned - was ignored by the users. Annoying popup lead users to simply disable notifications.

In addition - triggering the git command rm --cached --force {path} may be a bit dangerous especially when Project.getBaseDir has been deprecated in IDE SDK (https://github.com/JetBrains/intellij-community/blob/master/platform/core-api/src/com/intellij/openapi/project/Project.java#L44) - files location may be a bit different than expected (multiple modules).