Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a memory leak #1660

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Fix a memory leak #1660

merged 1 commit into from
Oct 28, 2024

Conversation

elijah-semyonov
Copy link

@elijah-semyonov elijah-semyonov commented Oct 28, 2024

Add missing dispose call.

Fixes https://youtrack.jetbrains.com/issue/CMP-6933/There-seems-to-be-a-memory-leak-in-the-iOS-system

Testing

https://youtrack.jetbrains.com/issue/CMP-6933/There-seems-to-be-a-memory-leak-in-the-iOS-system no longer leaks

Release Notes

Fixes - iOS

  • Memory leak due to Compose view controller never GCed.

@elijah-semyonov elijah-semyonov self-assigned this Oct 28, 2024
@elijah-semyonov elijah-semyonov changed the title Fix memory leak Fix a memory leak Oct 28, 2024
@elijah-semyonov elijah-semyonov merged commit 5bc3e63 into jb-main Oct 28, 2024
7 checks passed
@elijah-semyonov elijah-semyonov deleted the es/another-memory-leak-fix branch October 28, 2024 14:00
@xinzhengzhang
Copy link

@elijah-semyonov
Hi, we are using compose1.7. This issue leak problem is a bit serious to our situation. At the same time, because ComposeHostingViewController is internal, I don't have a good way to workaround outside. Can you release a snapshot version based on 1.7 plus this fix?

elijah-semyonov added a commit that referenced this pull request Nov 11, 2024
@MatkovIvan
Copy link
Member

@xinzhengzhang it's included into 1.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants