Introduce minimal virtual keyboard support #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 691b10e.
eymar
reviewed
Apr 11, 2024
| import org.w3c.dom.HTMLTextAreaElement | ||
| import org.w3c.dom.events.KeyboardEvent | ||
|
|
||
| internal class SynchronizedTextArea( |
There was a problem hiding this comment.
minor question. IMO, 'Synchornized' conveys a meaning that it has something to do with safe concurrent usage (at least the first thought was like this).
In this case, maybe it can named something like ShadowTextArea or TextAreaProxy?
Or adding a couple of kdoc lines can help quickly clarify the purpose of this class.
There was a problem hiding this comment.
I agree let me actually do both - rename it and add some documentation
eymar
reviewed
Apr 11, 2024
| import androidx.compose.ui.text.input.PlatformTextInputService | ||
| import androidx.compose.ui.text.input.TextFieldValue | ||
|
|
||
| class WebKeyboardInputService : PlatformTextInputService { |
There was a problem hiding this comment.
does it need to be public? Can it be internal?
There was a problem hiding this comment.
no, it is not supposed to be public, will push a fix, thank you for noticing it
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.