deprecate: Raise deprecation levels of API property setters #2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The properties useNestedTransactions, defaultFetchSize, and defaultIsolationLevel have deprecated setters since around version 0.35.1, since they were moved to DatabaseConfig builder and only left in for testing. DatabaseTestsBase methods have been refactored to accept a configuration parameter so that withTables() for example can easily pass these properties to TestDB.connect() as a builder. The deprecation level of the properties has been raised to ERROR.
- Rebase from main - Remove redundant test column qualifiers
bog-walk
force-pushed
the
bog-walk/deprecate-test-only-api
branch
from
c052c19 to
1cc1c5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change: Raise the deprecation levels of property setters that were deprecated after
DatabaseConfigwas implemented. The deprecation level has remained untouched because they were being used for testing purposes.Detailed description:
The following elements have been deprecated since around 0.35.1 ->
Raise from WARNING to ERROR:
Database.useNestedTransactionsDatabase.defaultFetchSizeThreadLocalTransactionManager.defaultIsolationLevelWhy: [Test refactoring]
For the last remaining property used in tests, the only current alternative to setting the deprecated property would be to either store a configured
Database.connect()instance in a variable or useTestDB.connect { setter }. Both then require using new transaction blocks and manually creating and dropping tables, which becomes tedious if multiple tables and dialects are being tested.How:
DatabaseTestsBasemethods,withDb(),withTables(), andwithSchemas(), now have a parameter that accepts a configuration builder, which is more easily passed to the call toconnect().Some logic has been added to base
withDb()to make sure that any database that stays registered for the entire test suite only retains the set configuration for that single call.Type of Change
Please mark the relevant options with an "X":
Affected databases:
Checklist
Related Issues