feat: Include DROP statements for unmapped indices in list of statements returned by statementsRequiredForDatabaseMigration function
#2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joc-a
force-pushed
the
joc/drop-unmapped-indices
branch
from
597728b to
783810e
Compare
e5l
approved these changes
Mar 9, 2024
exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/SchemaUtils.kt
Outdated
Show resolved
Hide resolved
…nts returned by `statementsRequiredForDatabaseMigration` function A separate function was introduced to keep the behaviour in the older functions the same.
joc-a
force-pushed
the
joc/drop-unmapped-indices
branch
from
783810e to
4f08b53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, for indices that exist in the database but are not mapped in the code, only a warning was logged, but their DROP statements were not included in the statements returned by the
statementsRequiredForDatabaseMigrationfunction. This PR changes that.A separate function was introduced to keep the behaviour in the older functions the same and limit this change to the
statementsRequiredForDatabaseMigrationfunction.