fix: EXPOSED-292 Explicit nulls in insert with databaseGenerated() #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a generated/computed column is marked as such using databaseGenerated(), but it is also nullable(), an exception is thrown even when the field is correctly excluded in an insert() block. This occurs because a NULL value is still being auto-included for that column in the prepared insert statement. This fix ensures that the column is excluded from adding an SQL NULL if it is marked as database generated. The class property is also included wherever a column is copied to ensure that swapping chained calls produces the same result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a generated/computed column is marked as such using
databaseGenerated(), but it is alsonullable(), an exception is thrown even when the field is correctly excluded from aninsert()block.This occurs because a NULL value is still being auto-included for that column in the prepared insert statement.
Additional:
isDatabaseGeneratedproperty to places whereColumnis copied, so that, for example, switching the chain order leads to equivalent results:.nullable().databaseGenerated()vs.databaseGenerated().nullable()