chore: Add Kdocs and update DSL for AllAnyFromBaseOp feature #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing KDocs for all new features - Make UntypedAndUnsizedArrayColumnType internal - Edit tests to reflect new DSL
bog-walk
commented
Jan 5, 2024
Comment on lines
-1006
to
+1013
| object UntypedAndUnsizedArrayColumnType : ColumnType() { | ||
| /** | ||
| * Array column for storing arrays of any size and type. | ||
| * | ||
| * This column type only exists to allow registering an array as a valid SQL type for statement clauses generated | ||
| * using `anyFrom(array)` and `allFrom(array)`. It does not correctly process arrays for use in `nonNullValueToString()` | ||
| * and will be replaced with a full implementation of ArrayColumnType. | ||
| */ | ||
| internal object UntypedAndUnsizedArrayColumnType : ColumnType() { |
There was a problem hiding this comment.
A YT issue has been created for the proper implementation of an array column type.
bog-walk
commented
Jan 5, 2024
| val testDBsSupportingInAnyAllFromTables = TestDB.postgreSQLRelatedDB + TestDB.allH2TestDB | ||
| private val testDBsSupportingInAnyAllFromTables = TestDB.postgreSQLRelatedDB + TestDB.allH2TestDB |
There was a problem hiding this comment.
This should include MySQL8 as well, but tests will fail due to the current issue with gradle task testMySql8. A YT issue has been created to add the dialect to the tests once that issue is resolved.
e5l
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UntypedAndUnsizedArrayColumnTypeinternal (to be replaced by a dedicatedArrayColumnTypein the future)