docs: [SQL Server, Oracle] Edit KDocs for Op.TRUE/FALSE #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current KDocs are potentially misleading in that it seems like the operator could be used both as a standalone value and on the right-hand side of a comparison operator. For most databases, this works, but will lead to a syntax error in SQL Server and Oracle. The new KDocs clarify that they represent operators that always evaluate to a boolean value, so using them on the right-hand side is not the intention.
bog-walk
changed the title
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current KDocs are misleading for the actual behavior of
Op.TRUEandOp.FALSEas they make it seem like the objects simply translate to the SQL types fortrueandfalse.This is technically correct for databases that support conventional boolean data types, so the objects can be used either as a stand-alone operator or as the left- or right-hand side of any comparison operator.
But for SQL Server and Oracle, which do not support syntax like
WHERE 1orWHERE TRUE, the object's logic returns an operator that always evaluates to a boolean, like1 = 1. So attempting to use these objects as the left- or right-hand side of any comparison operator will cause a syntax error.booleanLiteral()orbooleanParam()should be used in these situations.