fix: EXPOSED-242 [PostgreSQL] Cannot change connection setting in middle of a transaction #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ansaction Exposed attempts to reset connection settings (isolation level and read only) every time a new transaction is created, if the transaction settings don't match the default settings. This is regardless of whether a connection pool is being used with its own connection settings. The first half of this issue has already been fixed (PR 1943) so the next exception thrown becomes: "Cannot change transaction read only in the middle of a transaction." The same cache and check implementation for that fix has now been applied to the read only setting when a new transaction is created.
…dle of a tansaction Move tests to PostgreSQL package.
…dle of a transaction Adjust Spring connection spy tests as readOnly no longer set on every connection.
bog-walk
commented
Dec 19, 2023
| assertTrue(con1.verifyCallOrder("setReadOnly", "setAutoCommit", "commit", "close")) | ||
| assertTrue(con1.verifyCallOrder("setAutoCommit", "commit", "close")) |
There was a problem hiding this comment.
These Spring tests use a DataSourceSpy to mock connections and save calls to setReadOnly() as part of transaction connection calls.
The test output has changed since readOnly is no longer unnecessarily set on every connection, since its value never changes.
e5l
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lazy property initializer of a new database connection attempts to reset parameters (like transaction isolation level and read only mode), regardless of whether connections are being reused from a connection pool instance.
This can be observed, for example, when schema settings are placed in
HikariConfig, which opens a database transaction leading to thrown exceptions when Exposed later attempts to reset parameters:This PR builds on the changes introduced in PR #1943 by also retrieving and caching the
readOnlymode set by theDataSourceand avoiding redundant resets.Note: To ensure that these resets are avoided and that the
DataSourceis the single source of truth, duplicate settings should not be placed inDatabaseConfig(otherwise Exposed will treat these as overrides, as it already does for per-transaction parameter settings).