[MySQL] Fix bug when inserted ids are not returned if rewriteBatchedStatements property set to true
#1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Statements` property set to true
|
Could you check the CI? |
|
It looks like it some flaky test. re-run helps |
saral
pushed a commit
to saral/Exposed
that referenced
this pull request
Oct 3, 2023
…Statements` property set to true (JetBrains#1873)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rewriteBatchedStatements property is on mysql driver returns -2 as for each row returned by PreparedStatement.batchUpdate function. And when the whole array is summed up (#1641) it results in negative value as nothing where inserted.