Fix how changes are calculated for non-default schema table #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AlexeySoshin Is there any progress here or when will you release the next version? |
bog-walk
reviewed
Apr 28, 2023
There was a problem hiding this comment.
@AlexeySoshin Thanks for all your contributions to the project btw.
...test/kotlin/org/jetbrains/exposed/sql/tests/shared/ddl/CreateMissingTablesAndColumnsTests.kt
Outdated
Show resolved
Hide resolved
BierDav
suggested changes
Aug 13, 2023
exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/Table.kt
Outdated
Show resolved
Hide resolved
bog-walk
force-pushed
the
1661-create-missing-columns-table-different-schema
branch
from
2f5e464 to
8859614
Compare
Add comment to private function.
bog-walk
approved these changes
Aug 31, 2023
e5l
approved these changes
Sep 4, 2023
BierDav
approved these changes
Sep 4, 2023
|
LGMT |
AlexeySoshin
deleted the
1661-create-missing-columns-table-different-schema
branch
saral
pushed a commit
to saral/Exposed
that referenced
this pull request
Oct 3, 2023
…s#1678) Allow schema-prefixed table names to be used with SchemaUtils validating functions. Ensure tables with index and foreign key names are also covered when changes are assessed. Co-authored-by: Chantal Loncle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1661