IsAutoCommit = false & transactionIsolation = "Transaction_Serializab…

…le" result in a PSQLException #1575
JetBrains · Nov 14, 2022 · dfb63d2 · dfb63d2
1 parent 2bea43b
commit dfb63d2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/statements/api/ExposedBlob.kt b/exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/statements/api/ExposedBlob.kt
@@ -11,7 +11,6 @@ class ExposedBlob(val inputStream: InputStream) {
         if (this === other) return true
         if (other !is ExposedBlob) return false
 
-
         if (!bytes.contentEquals(other.bytes)) return false
 
         return true

diff --git a/...e/src/main/kotlin/org/jetbrains/exposed/sql/transactions/ThreadLocalTransactionManager.kt b/...e/src/main/kotlin/org/jetbrains/exposed/sql/transactions/ThreadLocalTransactionManager.kt
@@ -75,11 +75,12 @@ class ThreadLocalTransactionManager(
         private val connectionLazy = lazy(LazyThreadSafetyMode.NONE) {
             outerTransaction?.connection ?: db.connector().apply {
                 setupTxConnection?.invoke(this, this@ThreadLocalTransaction) ?: run {
-                    // The order of `setReadOnly` and `setAutoCommit` is important.
+                    // The order of setters here is important.
+                    // Transaction isolation should go first as the readOnly or autoCommit can start transaction with wrong isolation level
                     // Some drivers start a transaction right after `setAutoCommit(false)`,
                     // which makes `setReadOnly` throw an exception if it is called after `setAutoCommit`
-                    readOnly = this@ThreadLocalTransaction.readOnly
                     transactionIsolation = this@ThreadLocalTransaction.transactionIsolation
+                    readOnly = this@ThreadLocalTransaction.readOnly
                     autoCommit = false
                 }
             }