Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove distutils.dist.Distribution.announce from the blacklist #63

Merged
merged 1 commit into from
Feb 26, 2023

Conversation

AlexWaygood
Copy link
Contributor

@AlexWaygood AlexWaygood commented Feb 26, 2023

This is no longer necessary following python/typeshed#9795: stubtest now passes for typeshed's setuptools stubs even if the correct default parameter is added to the stdlib stub for distutils.dist.Distribution.announce

Following python/typeshed#9795, stubtest now passes for typeshed's `setuptools` stubs even if the correct default parameter is added to the stdlib stub for `distutils.dist.Distribution.announce`
@github-actions
Copy link

⚠ Diff showing the effect of this PR on how stubdefaulter would alter typeshed's stdlib:

diff --git a/stdlib/distutils/dist.pyi b/stdlib/distutils/dist.pyi
index dfffdc5..e0d2fa5 100644
--- a/stdlib/distutils/dist.pyi
+++ b/stdlib/distutils/dist.pyi
@@ -103,7 +103,7 @@ class Distribution:
     def get_command_packages(self): ...
     def get_command_class(self, command): ...
     def reinitialize_command(self, command, reinit_subcommands: int = 0): ...
-    def announce(self, msg, level: int = ...) -> None: ...
+    def announce(self, msg, level: int = 2) -> None: ...
     def run_commands(self) -> None: ...
     def run_command(self, command) -> None: ...
     def has_pure_modules(self): ...

@JelleZijlstra JelleZijlstra merged commit af28d99 into JelleZijlstra:main Feb 26, 2023
@AlexWaygood AlexWaygood deleted the patch-1 branch February 26, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants