add pre-commit support. #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there no way to let the pre-commit hook take whatever arguments autotyping itself accepts? Doesn't seem ideal to have to hardcode specific arguments. |
|
yep, we can do that! ^ |
|
hey @JelleZijlstra, I can't seem to reproduce the failing CI error at my end, would you have any insights why this could be happening? |
|
I'm not entirely sure; it's possible I need to cut a new release of pyanalyze. I'll look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pre-commit support for the project. I've felt hooks for
--safeand--aggressiveshould cover most use-cases but I'll be happy to include others if that appears better.Closes #75.