Skip to content

Commit

Permalink
[SPARK-33936][SQL] Add the version when connector's methods and inter…
Browse files Browse the repository at this point in the history
…faces were updated

### What changes were proposed in this pull request?
Add the `since` tag to methods and interfaces added recently.

### Why are the changes needed?
1. To follow the existing convention for Spark API.
2. To inform devs when Spark API was changed.

### Does this PR introduce _any_ user-facing change?
Should not.

### How was this patch tested?
`dev/scalastyle`

Closes apache#30966 from MaxGekk/spark-23889-interfaces-followup.

Authored-by: Max Gekk <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
  • Loading branch information
MaxGekk authored and dongjoon-hyun committed Dec 29, 2020
1 parent c425024 commit 2b6836c
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@
* example, a partition value produced by bucket(id, 16) could be exposed by a metadata column. In
* this case, {@link #transform()} should return a non-null {@link Transform} that produced the
* metadata column's values.
*
* @since 3.1.0
*/
@Evolving
public interface MetadataColumn {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ public interface SupportsDelete {
*
* @param filters filter expressions, used to select rows to delete when all expressions match
* @return true if the delete operation can be performed
*
* @since 3.1.0
*/
default boolean canDeleteWhere(Filter[] filters) {
return true;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@
* If a table column and a metadata column have the same name, the metadata column will never be
* requested. It is recommended that Table implementations reject data column name that conflict
* with metadata column names.
*
* @since 3.1.0
*/
@Evolving
public interface SupportsMetadataColumns extends Table {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,8 @@ public static Transform hours(String column) {
* @param direction direction of the sort
* @param nullOrder null order of the sort
* @return a SortOrder
*
* @since 3.2.0
*/
public static SortOrder sort(Expression expr, SortDirection direction, NullOrdering nullOrder) {
return LogicalExpressions.sort(expr, direction, nullOrder);
Expand Down

0 comments on commit 2b6836c

Please sign in to comment.