fix(validation): exepenses details validation

JarodCouprie · Sep 3, 2024 · 3e59589 · 3e59589
1 parent 31673ba
commit 3e59589
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/api-server/src/resources/expense/ExpenseController.ts b/api-server/src/resources/expense/ExpenseController.ts
@@ -553,7 +553,6 @@ router.get("/:id", verifyToken, async (req: Request, res: Response) => {
   let userId = (req as CustomRequest).token.userId;
   const { code, message, data } = await ExpenseService.getExpenseDemand(
     req.params.id,
-    userId,
   );
   res.status(code).json({ message, data });
 });

diff --git a/api-server/src/resources/expense/ExpenseService.ts b/api-server/src/resources/expense/ExpenseService.ts
@@ -229,7 +229,7 @@ export class ExpenseService {
     }
   }
 
-  public static async getExpenseDemand(id: string, userId: number) {
+  public static async getExpenseDemand(id: string) {
     try {
       const expenseTemp = await ExpenseRepository.getExpenseDemand(id);
       let expense: ExpenseListDTO;
@@ -241,8 +241,6 @@ export class ExpenseService {
       } else {
         expense = new ExpenseListDTO(expenseTemp);
       }
-      if (expense.id_owner != userId)
-        return new ControllerResponse(403, "Access denied");
 
       return new ControllerResponse<ExpenseListDTO>(200, "", expense);
     } catch (error) {