Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET Meteor does not load if no Android SDK can be found #37

Closed
PurpleGranite opened this issue Feb 15, 2023 · 2 comments
Closed

.NET Meteor does not load if no Android SDK can be found #37

PurpleGranite opened this issue Feb 15, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@PurpleGranite
Copy link

My use-case for this extension is to assist running a MAUI app which will run only under WinUI. I have found that the extension fails to load if there is no installed Android SDK.

To work around this, I have made the following changes to the local files for the extension (version 1.71.0):

// resources.js
exports.messageAndroidSdkNotFound = "Android SDK Path not found. Make sure you have installed a supported Android SDK.";
// tasks/build.js
...
constructor() {
  try {
    this.androidSdkDirectory = bridge_2.CommandInterface.androidSdk();
  }
  catch { 
    vscode.window.showErrorMessage(res.messageAndroidSdkNotFound);
  }
}
...

This allows the extension to keep loading, displaying a warning to the user instead of dropping an exception into the extension host log.

Logging as an issue, rather than a PR, to enable discussion and in case there is a more elegant way that loading without an installed Android SDK can be achieved.

@JaneySprings JaneySprings added the bug Something isn't working label Feb 15, 2023
@JaneySprings
Copy link
Owner

Hello! Thank you for your issue. I have already fixed this bug and will release an update soon.

@JaneySprings
Copy link
Owner

Fixed in 62c1ba7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants