Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package name conflict #8

Open
wants to merge 3 commits into
base: stable
Choose a base branch
from

Conversation

jjorn
Copy link

@jjorn jjorn commented Apr 24, 2019

Problem

Due to the conflict between the main class name and package name, MungoHealer, the compiler is not able to access to a framework entity via package name i.e. MungoHealer.ErrorHandler, as described in thread #6.

Solution

Renaming the main class from MungoHealer to Mungo as suggested in thread #6.

Copy link
Contributor

@Jeehut Jeehut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks good overall. But it still doesn't explain why it didn't work earlier in the first place. It sounds like a bug in Swift to me if nothing else. So, either there aready is a related bug report on the Swift Forums / Swift JIRA or we should create one and link it within the issue, so we can track prograss and possibly revert the renaming, once it's fixed.

@jjorn
Copy link
Author

jjorn commented Apr 26, 2019

Yes you're right. Someone has found similar issue and already reported in SR-5304. Hopefully, it will be resolved in the next Swift version.

The issue is not critical. You can ignore this PR.

@Jeehut
Copy link
Contributor

Jeehut commented Apr 27, 2019

The issue seems to be open since quite some time now. So I'd say, we should fix it within this library nevertheless.

@Jeehut
Copy link
Contributor

Jeehut commented Apr 27, 2019

Plese rebase this. I'll merge once the CI passes.

@jjorn jjorn force-pushed the work/fix-package-name-conflict branch from 0b7c68d to da04aba Compare April 29, 2019 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants