Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the textmate scope to include \refcite to citation command #3597

Closed
wants to merge 1 commit into from
Closed

Update the textmate scope to include \refcite to citation command #3597

wants to merge 1 commit into from

Conversation

scaomath
Copy link

Motivation

In World Scientific $\LaTeX$ template, there is a citation macro \refcite{ }.
For example, please check this Overleaf template

Proposed changes

While the cite part still triggers the extension to do auto-completion, the token does not trigger the syntax highlighting because there is no scope on what is inside the parenthesis (see below), this PR adds that (a very simple change).

Before

Screenshot from 2022-12-24 08-46-38

After (build locally using Node.js)

Screenshot from 2022-12-24 09-17-36

jlelong added a commit to jlelong/vscode-latex-basics that referenced this pull request Dec 24, 2022
@jlelong
Copy link
Collaborator

jlelong commented Dec 24, 2022

Thank you for your PR. We have outsourced our LaTeX syntax highlighting grammar to vscode-latex-basics. This is fixed by jlelong/vscode-latex-basics@9a4fb37 and 8928410

@jlelong jlelong closed this Dec 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants