Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml and drop setup.py #11

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

terop
Copy link

@terop terop commented Nov 10, 2023

This is one step towards adding pycaruna to PyPI.

@Jalle19
Copy link
Owner

Jalle19 commented Nov 13, 2023

I had for some reason unwatched this repository so I didn't get notified about your PRs. Happened to stumble upon them when I today wanted to debug why the authentication doesn't work anymore!

@Jalle19
Copy link
Owner

Jalle19 commented Nov 13, 2023

Is it necessary to move the files to src/?

@Jalle19
Copy link
Owner

Jalle19 commented Nov 13, 2023

Seems like something like this should be added instead of moving to src/:

packages = [
    { include = "pycaruna" }
]

@Jalle19
Copy link
Owner

Jalle19 commented Nov 13, 2023

Maybe it's fine like this, I'm not familiar with pyproject.toml to be honest. Please rebase so we can get this in.

@terop
Copy link
Author

terop commented Nov 13, 2023

Actually moving the directory seems not to be needed. When I originally did this I got some odd error but now when I tried this again it worked fine.

@Jalle19
Copy link
Owner

Jalle19 commented Nov 13, 2023

Is the README instructions on how to include this library still working? Or will it need adapting now?

git+https://github.com/Jalle19/pycaruna.git@51d3ee12429d68592640cb146ead71541bf14944#egg=pycaruna==1.0.0

This is one step towards adding pycaruna to PyPI.
@terop
Copy link
Author

terop commented Nov 13, 2023

An update is needed, I modified README.md to use the new working syntax.

@Jalle19 Jalle19 merged commit c0c2a87 into Jalle19:master Nov 13, 2023
@Jalle19
Copy link
Owner

Jalle19 commented Nov 13, 2023

Thanks!

@terop terop deleted the add_pyproject branch November 13, 2023 17:37
@terop
Copy link
Author

terop commented Nov 13, 2023

I think that pycaruna would now be ready for publishing on PyPI. Some documentation on doing this is available at https://packaging.python.org/en/latest/tutorials/packaging-projects.
@Jalle19 could you try PyPI publishing when you have time?

@Jalle19
Copy link
Owner

Jalle19 commented Nov 13, 2023

Yeah, I'll have a look

@Jalle19
Copy link
Owner

Jalle19 commented Nov 14, 2023

https://pypi.org/project/pycaruna/ should be published now. Haven't tried using the released build yet, let's hope it works!

@terop
Copy link
Author

terop commented Nov 14, 2023

Thanks!
I tried using the package from PyPI and it works okay for me.

@Jalle19
Copy link
Owner

Jalle19 commented Nov 14, 2023

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants