-
Notifications
You must be signed in to change notification settings - Fork 61
Conversation
@@ -39,7 +39,7 @@ | |||
|
|||
<rule ref="Generic.Files.LineLength"> | |||
<properties> | |||
<property name="lineLimit" value="125"/> | |||
<property name="lineLimit" value="135"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather use multi-line constructor. This rule is quite important
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public function __construct(
PhpExecutable $phpExecutable,
$fileToCheck,
$aspTags = false,
$shortTag = false,
$deprecated = false)
{
FILE: /private/var/www/PHP-Parallel-Lint/src/Process/LintProcess.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
29 | ERROR | [x] The closing parenthesis of a multi-line function
| | declaration must be on a new line
| | (PEAR.Functions.FunctionDeclaration.CloseBracketLine)
30 | ERROR | [x] The closing parenthesis and the opening brace of a
| | multi-line function declaration must be on the same
| | line
| | (PEAR.Functions.FunctionDeclaration.NewlineBeforeOpenBrace)
public function __construct(
PhpExecutable $phpExecutable,
$fileToCheck,
$aspTags = false,
$shortTag = false,
$deprecated = false
)
{
31 | ERROR | [x] The closing parenthesis and the opening brace of a
| | multi-line function declaration must be on the same
| | line
| | (PEAR.Functions.FunctionDeclaration.NewlineBeforeOpenBrace)
public function __construct(
PhpExecutable $phpExecutable,
$fileToCheck,
$aspTags = false,
$shortTag = false,
$deprecated = false
) {
Opening brace should be on a new line
| | (Generic.Functions.OpeningFunctionBraceBsdAllman.BraceOnSameLine)
So, isn't possible with this ruleset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Crazy :D
I think I've disabled one of those rules for these reasons.
ping @JakubOnderka |
@mzk Sorry for late reply. Can you please resolve conflicts and rebase to current master? Then I will merge it and release new version |
@JakubOnderka What took so long? Waiting for a conflict? Frequent release prevents conflicts. |
1b1857c
to
c084943
Compare
Rebased, tests passed. @JakubOnderka |
ping @JakubOnderka |
Thanks for adding this @mzk, I was going to file a bug for this feature request :-) @JakubOnderka, would it be possible to have a new release/tag for this feature? |
The `--show-deprecated` option was added to PHP Parallel Lint some years ago, but never documented, so I never knew it existed. Enabling this option allows for deprecations which can be detected at compile time to be shown (in contrast to deprecations which can only be detected at run-time). Refs: * php-parallel-lint/PHP-Parallel-Lint#81 * JakubOnderka/PHP-Parallel-Lint#94
ref mzk#1