client.rs: remove items from 'items' variable when receiving remove e…

[Levizor]

Client contains items field which stores all the tray items in a HashMap.
Upon receiving a new item client adds it to the mentioned map, so I assume that this map should be synchronized with the real state of the tray. However, when we receive a remove update, the item isn't cleaned from the map, which I find strange. I also don't see updates supplied to this map, so maybe it should be as well implemented.

So my suggestions is to remove items when we receive respective update. If you open and close an application that adds items to a tray now, it will be duplicated over and over, which is clearly not intended.

This problem was mentioned in this issue.

[JakeStanger]

Thanks for this. That'd certainly explain it.

Yes, that items map is supposed to be kept up to date to reflect the current state, as its how the current state is retrieved from an existing client (ie to be able to rebuild on reload).

You might find that updates are okay, as it's a map of HashMaps so updating the inner map will already update the outer state, unless I missed that too?

[Levizor]

No, I guess you're right about updates. I missed that part. I'll remove the comment and rebase.

[Levizor]

Sorry about my formatter, should I make function calls in one line?

[JakeStanger]

Sorry about my formatter, should I make function calls in one line?

It's using the default cargo fmt settings so whatever that does :P