-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Represent non-stringified JSON request body as an [object Obj…
…ect] string" This reverts commit 5c6b055.
- Loading branch information
1 parent
90fb680
commit e42f201
Showing
1 changed file
with
1 addition
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e42f201
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JakeChampion Is it possible to re-introduce this code as it solves the issue in #856. Happy to make a new PR with this code refactored if it introduced a regression elsewhere?
e42f201
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be useful to learn why this was reverted, so we can come up with the proper solution. Thank you for your time with this!
e42f201
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reversion was to fix these reported issues -- #923 #922 #918
e42f201
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification, @JakeChampion! Please, can we collaborate to still provide the fix but account for all the areas it previously broke?
e42f201
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have time to work on it myself, I'm happy to review a pull-request which does that 👍